Implement extension controlled indicators, starting with New Tab page

chrome/browser/resources/settings/on_startup_page/on_startup_page.html

Index: chrome/browser/resources/settings/on_startup_page/on_startup_page.html
diff --git a/chrome/browser/resources/settings/on_startup_page/on_startup_page.html b/chrome/browser/resources/settings/on_startup_page/on_startup_page.html
index 841f56b9f762f29cf30ebb023357809443f970e4..1145e0706ab2fde26e5e6b9b1e83add027d3245f 100644
--- a/chrome/browser/resources/settings/on_startup_page/on_startup_page.html
+++ b/chrome/browser/resources/settings/on_startup_page/on_startup_page.html
@@ -1,7 +1,9 @@
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout.html">
 <link rel="import" href="/controls/controlled_radio_button.html">
+<link rel="import" href="/controls/extension_controlled_indicator.html">
 <link rel="import" href="/controls/settings_radio_group.html">
+<link rel="import" href="/on_startup_page/on_startup_browser_proxy.html">
 <link rel="import" href="/on_startup_page/startup_urls_page.html">
 <link rel="import" href="/settings_shared_css.html">
 
@@ -15,6 +17,15 @@
             pref="[[prefs.session.restore_on_startup]]">
           $i18n{onStartupOpenNewTab}
         </controlled-radio-button>
+        <template is="dom-if" if="[[showIndicator_(
+            ntpExtension_, prefs.session.restore_on_startup.value)]]">
+          <extension-controlled-indicator
+              extension-id="[[ntpExtension_.id]]"

[dpapad, 2016/11/17 01:16:46]

Could we pass all params at once as follows?

<extension-controlled-indicator
extension="[[ntpExtension_]]"></<extension-controlled-indicator>

And rename NtpExtension typedef to just Extension?

[Dan Beam, 2016/11/17 01:33:11]

not really because this information lives on

prefs.<pref_name>.extensionId
prefs.<pref_name>.controlledByName
prefs.<pref_name>.extensionCanBeDisabled

in other cases

[dpapad, 2016/11/17 01:50:07]

Hm, ok. We could still package the 3 variables into a single object and pass it
in. I guess either way the interface of extension-controlled-indicator would
favor some cases over the others.

[Dan Beam, 2016/11/17 02:50:14]

Acknowledged.

+              extension-name="[[ntpExtension_.name]]"
+              extension-can-be-disabled="[[ntpExtension_.canBeDisabled]]"
+              on-extension-disable="getNtpExtension_">
+          </extension-controlled-indicator>
+        </template>
         <controlled-radio-button name="[[prefValues_.CONTINUE]]"
             pref="[[prefs.session.restore_on_startup]]">
           $i18n{onStartupContinue}