Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="chrome://resources/html/polymer.html"> | 1 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> | 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> |
| 3 <link rel="import" href="/controls/controlled_radio_button.html"> | 3 <link rel="import" href="/controls/controlled_radio_button.html"> |
| 4 <link rel="import" href="/controls/extension_controlled_indicator.html"> | |
| 4 <link rel="import" href="/controls/settings_radio_group.html"> | 5 <link rel="import" href="/controls/settings_radio_group.html"> |
| 6 <link rel="import" href="/on_startup_page/on_startup_browser_proxy.html"> | |
| 5 <link rel="import" href="/on_startup_page/startup_urls_page.html"> | 7 <link rel="import" href="/on_startup_page/startup_urls_page.html"> |
| 6 <link rel="import" href="/settings_shared_css.html"> | 8 <link rel="import" href="/settings_shared_css.html"> |
| 7 | 9 |
| 8 <dom-module id="settings-on-startup-page"> | 10 <dom-module id="settings-on-startup-page"> |
| 9 <template> | 11 <template> |
| 10 <style include="settings-shared"></style> | 12 <style include="settings-shared"></style> |
| 11 <div class="settings-box block first"> | 13 <div class="settings-box block first"> |
| 12 <settings-radio-group id="onStartupRadioGroup" | 14 <settings-radio-group id="onStartupRadioGroup" |
| 13 pref="{{prefs.session.restore_on_startup}}"> | 15 pref="{{prefs.session.restore_on_startup}}"> |
| 14 <controlled-radio-button name="[[prefValues_.OPEN_NEW_TAB]]" | 16 <controlled-radio-button name="[[prefValues_.OPEN_NEW_TAB]]" |
| 15 pref="[[prefs.session.restore_on_startup]]"> | 17 pref="[[prefs.session.restore_on_startup]]"> |
| 16 $i18n{onStartupOpenNewTab} | 18 $i18n{onStartupOpenNewTab} |
| 17 </controlled-radio-button> | 19 </controlled-radio-button> |
| 20 <template is="dom-if" if="[[showIndicator_( | |
| 21 ntpExtension_, prefs.session.restore_on_startup.value)]]"> | |
| 22 <extension-controlled-indicator | |
| 23 extension-id="[[ntpExtension_.id]]" | |
|
dpapad
2016/11/17 01:16:46
Could we pass all params at once as follows?
<ext
Dan Beam
2016/11/17 01:33:11
not really because this information lives on
pref
dpapad
2016/11/17 01:50:07
Hm, ok. We could still package the 3 variables int
Dan Beam
2016/11/17 02:50:14
Acknowledged.
| |
| 24 extension-name="[[ntpExtension_.name]]" | |
| 25 extension-can-be-disabled="[[ntpExtension_.canBeDisabled]]" | |
| 26 on-extension-disable="getNtpExtension_"> | |
| 27 </extension-controlled-indicator> | |
| 28 </template> | |
| 18 <controlled-radio-button name="[[prefValues_.CONTINUE]]" | 29 <controlled-radio-button name="[[prefValues_.CONTINUE]]" |
| 19 pref="[[prefs.session.restore_on_startup]]"> | 30 pref="[[prefs.session.restore_on_startup]]"> |
| 20 $i18n{onStartupContinue} | 31 $i18n{onStartupContinue} |
| 21 </controlled-radio-button> | 32 </controlled-radio-button> |
| 22 <controlled-radio-button name="[[prefValues_.OPEN_SPECIFIC]]" | 33 <controlled-radio-button name="[[prefValues_.OPEN_SPECIFIC]]" |
| 23 pref="[[prefs.session.restore_on_startup]]"> | 34 pref="[[prefs.session.restore_on_startup]]"> |
| 24 $i18n{onStartupOpenSpecific} | 35 $i18n{onStartupOpenSpecific} |
| 25 </controlled-radio-button> | 36 </controlled-radio-button> |
| 26 </settings-radio-group> | 37 </settings-radio-group> |
| 27 </div> | 38 </div> |
| 28 <template is="dom-if" | 39 <template is="dom-if" |
| 29 if="[[showStartupUrls_(prefs.session.restore_on_startup.value)]]"> | 40 if="[[showStartupUrls_(prefs.session.restore_on_startup.value)]]"> |
| 30 <settings-startup-urls-page></settings-startup-urls-page> | 41 <settings-startup-urls-page></settings-startup-urls-page> |
| 31 </template> | 42 </template> |
| 32 </template> | 43 </template> |
| 33 <script src="on_startup_page.js"></script> | 44 <script src="on_startup_page.js"></script> |
| 34 </dom-module> | 45 </dom-module> |
| OLD | NEW |