[MD settings] label for opening PDF in different application

[MD settings] label for opening PDF in different application

This CL changes the label for the setting about opening PDF documents
in a different application (rather than within the browser). Since the
meaning of the language opposite from the prior label, the |inverted|
tag has been removed from the toggle.

BUG=663588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/88bfc417f0244004b44720aec76f6bee1a9aaacb
Cr-Commit-Position: refs/heads/master@{#432583}

[dschuyler, 2016-11-16 00:02:21]

Description was changed from

==========
[MD settings] label for opening PDF in different application

This CL changes the label for the setting about opening PDF documents
in a different application (rather than within the browser). Since the
meaning of the language opposite from the prior label, the |inverted|
tag has been removed from the toggle.

BUG=614588
==========

to

==========
[MD settings] label for opening PDF in different application

This CL changes the label for the setting about opening PDF documents
in a different application (rather than within the browser). Since the
meaning of the language opposite from the prior label, the |inverted|
tag has been removed from the toggle.

BUG=614588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-11-16 00:02:24]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 00:03:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-11-16 00:06:10]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dschuyler, 2016-11-16 00:06:11]

https://codereview.chromium.org/2506803002/diff/1/chrome/app/settings_strings...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2506803002/diff/1/chrome/app/settings_strings...
chrome/app/settings_strings.grdp:1671: Open PDFs using a different application
This is the official text from Alan (replacing the text I'd suggested).

https://codereview.chromium.org/2506803002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/pdf_documents.html (right):

https://codereview.chromium.org/2506803002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/pdf_documents.html:9:
margin-top: 0;  /* Cancel separation between main and secondary text. */
Since there is no main text on this secondary text, it ended up making the text
display a little lower than center. This allows the text to be vertically
centered correctly.

https://codereview.chromium.org/2506803002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/pdf_documents.html:17:
on-change="onToggleChange_"
The setting now matches the way the pref is stored, so the |inverted| is not
longer used.

[dschuyler, 2016-11-16 00:06:39]

Description was changed from

==========
[MD settings] label for opening PDF in different application

This CL changes the label for the setting about opening PDF documents
in a different application (rather than within the browser). Since the
meaning of the language opposite from the prior label, the |inverted|
tag has been removed from the toggle.

BUG=614588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] label for opening PDF in different application

This CL changes the label for the setting about opening PDF documents
in a different application (rather than within the browser). Since the
meaning of the language opposite from the prior label, the |inverted|
tag has been removed from the toggle.

BUG=663588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-11-16 00:23:01]

lgtm

[commit-bot: I haz the power, 2016-11-16 01:27:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 01:27:36]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dschuyler, 2016-11-16 03:08:32]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-11-16 03:09:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 07:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 07:10:49]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dschuyler, 2016-11-16 18:59:35]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-11-16 19:00:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 19:13:08]

Description was changed from

==========
[MD settings] label for opening PDF in different application

This CL changes the label for the setting about opening PDF documents
in a different application (rather than within the browser). Since the
meaning of the language opposite from the prior label, the |inverted|
tag has been removed from the toggle.

BUG=663588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] label for opening PDF in different application

This CL changes the label for the setting about opening PDF documents
in a different application (rather than within the browser). Since the
meaning of the language opposite from the prior label, the |inverted|
tag has been removed from the toggle.

BUG=663588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-16 19:13:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-16 19:53:27]

Description was changed from

==========
[MD settings] label for opening PDF in different application

This CL changes the label for the setting about opening PDF documents
in a different application (rather than within the browser). Since the
meaning of the language opposite from the prior label, the |inverted|
tag has been removed from the toggle.

BUG=663588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] label for opening PDF in different application

This CL changes the label for the setting about opening PDF documents
in a different application (rather than within the browser). Since the
meaning of the language opposite from the prior label, the |inverted|
tag has been removed from the toggle.

BUG=663588
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/88bfc417f0244004b44720aec76f6bee1a9aaacb
Cr-Commit-Position: refs/heads/master@{#432583}
==========

[commit-bot: I haz the power, 2016-11-16 19:53:28]

Patchset 1 (id:??) landed as
https://crrev.com/88bfc417f0244004b44720aec76f6bee1a9aaacb
Cr-Commit-Position: refs/heads/master@{#432583}