Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2256)

Unified Diff: chrome/browser/resources/settings/site_settings/pdf_documents.html

Issue 2506803002: [MD settings] label for opening PDF in different application (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/pdf_documents.html
diff --git a/chrome/browser/resources/settings/site_settings/pdf_documents.html b/chrome/browser/resources/settings/site_settings/pdf_documents.html
index 8c02fa4bc184863b1bec939ef58223735e898a6a..98c0c18ac080058a492fc8446eef8343aac7d7df 100644
--- a/chrome/browser/resources/settings/site_settings/pdf_documents.html
+++ b/chrome/browser/resources/settings/site_settings/pdf_documents.html
@@ -4,13 +4,17 @@
<dom-module id="settings-pdf-documents">
<template>
- <style include="settings-shared"></style>
+ <style include="settings-shared">
+ .secondary {
+ margin-top: 0; /* Cancel separation between main and secondary text. */
dschuyler 2016/11/16 00:06:11 Since there is no main text on this secondary text
+ }
+ </style>
<div class="settings-box first two-line">
<div class="start secondary">
- $i18n{siteSettingsPdfInBrowser}
+ $i18n{siteSettingsPdfDifferentApplication}
</div>
<settings-toggle-button id="toggle" checked="{{categoryEnabled}}"
- inverted on-change="onToggleChange_"
+ on-change="onToggleChange_"
dschuyler 2016/11/16 00:06:11 The setting now matches the way the pref is stored
pref="{{prefs.plugins.always_open_pdf_externally}}">
</settings-toggle-button>
</div>

Powered by Google App Engine
This is Rietveld 408576698