Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 2506713002: Avoid parsing the webstore base url so much. (Closed)
Patch Set: fix chromeos Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index 7f544181e3fdb187381483c90ecc95a3d80d5fd0..24e0e25c3671cb85fedbb301a9460fcb4eb7287c 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -2898,15 +2898,15 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
// is partially controlled by the renderer, namely
// ChromeContentRendererClient. This test instead relies on the Web
// Store triggering such navigations.
- std::string webstore_url = extension_urls::GetWebstoreLaunchURL();
+ GURL webstore_url = extension_urls::GetWebstoreLaunchURL();
// Mock out requests to the Web Store.
base::FilePath file(GetTestPath("prerender_page.html"));
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
- base::Bind(&CreateMockInterceptorOnIO, GURL(webstore_url), file));
+ base::Bind(&CreateMockInterceptorOnIO, webstore_url, file));
- PrerenderTestURL(CreateClientRedirect(webstore_url),
+ PrerenderTestURL(CreateClientRedirect(webstore_url.spec()),
FINAL_STATUS_OPEN_URL, 1);
}

Powered by Google App Engine
This is Rietveld 408576698