chrome/browser/extensions/webstore_standalone_installer.cc - Issue 2506713002: Avoid parsing the webstore base url so much.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_standalone_installer.cc

Issue 2506713002: Avoid parsing the webstore base url so much. (Closed)

Patch Set: fix chromeos Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_standalone_installer.cc

diff --git a/chrome/browser/extensions/webstore_standalone_installer.cc b/chrome/browser/extensions/webstore_standalone_installer.cc

index 3809bdc358d75e99e8c54ecc239ab0d714c1995c..84f1905e3959975cd4237ff408facc824ade74e4 100644

--- a/chrome/browser/extensions/webstore_standalone_installer.cc

+++ b/chrome/browser/extensions/webstore_standalone_installer.cc

@@ -298,8 +298,7 @@ void WebstoreStandaloneInstaller::OnWebstoreResponseParseSuccess(

webstore_install::kInvalidWebstoreResponseError);

return;

}

- icon_url = GURL(extension_urls::GetWebstoreLaunchURL()).Resolve(

- icon_url_string);

+ icon_url = extension_urls::GetWebstoreLaunchURL().Resolve(icon_url_string);

if (!icon_url.is_valid()) {

CompleteInstall(webstore_install::INVALID_WEBSTORE_RESPONSE,

webstore_install::kInvalidWebstoreResponseError);