Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 2506583002: Worker: Fix wrong stack size calculation (Closed)

Created:
4 years, 1 month ago by nhiroki
Modified:
4 years, 1 month ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because a denominator sizeof(uint32_t*) in the calculation is not correct. This should have been sizeof(uint32_t). This CL fixes it. BUG=252492 Committed: https://crrev.com/7d9e75c30702cd9e0e206ebac8906b56389565dc Cr-Commit-Position: refs/heads/master@{#432267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
nhiroki
PTAL, thanks!
4 years, 1 month ago (2016-11-15 14:22:54 UTC) #12
haraken
LGTM
4 years, 1 month ago (2016-11-15 16:12:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506583002/20001
4 years, 1 month ago (2016-11-15 22:02:48 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-15 22:12:53 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 22:15:06 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d9e75c30702cd9e0e206ebac8906b56389565dc
Cr-Commit-Position: refs/heads/master@{#432267}

Powered by Google App Engine
This is Rietveld 408576698