|
|
DescriptionWorker: Fix wrong stack size calculation
Before this CL, stack size for worker threads is unexpectedly lowered than the
intended size (500KB) because a denominator sizeof(uint32_t*) in the calculation
is not correct. This should have been sizeof(uint32_t). This CL fixes it.
BUG=252492
Committed: https://crrev.com/7d9e75c30702cd9e0e206ebac8906b56389565dc
Cr-Commit-Position: refs/heads/master@{#432267}
Patch Set 1 #
Messages
Total messages: 20 (15 generated)
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB). This CL fixes the stack size calculation. BUG=252492 ========== to ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because the denominator is wrongly sizeof(uint32_t*). This should be sizeof(uint32_t). This CL fixes the calculation. BUG=252492 ==========
Description was changed from ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because the denominator is wrongly sizeof(uint32_t*). This should be sizeof(uint32_t). This CL fixes the calculation. BUG=252492 ========== to ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because the denominator in the calculation is wrongly sizeof(uint32_t*). This should have been sizeof(uint32_t). This CL fixes the calculation. BUG=252492 ==========
Description was changed from ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because the denominator in the calculation is wrongly sizeof(uint32_t*). This should have been sizeof(uint32_t). This CL fixes the calculation. BUG=252492 ========== to ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because a denominator in the calculation is wrongly sizeof(uint32_t*). This should have been sizeof(uint32_t). This CL fixes it. BUG=252492 ==========
nhiroki@chromium.org changed reviewers: + haraken@chromium.org
PTAL, thanks!
Description was changed from ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because a denominator in the calculation is wrongly sizeof(uint32_t*). This should have been sizeof(uint32_t). This CL fixes it. BUG=252492 ========== to ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because a denominator in the calculation is wrong sizeof(uint32_t*). This should have been sizeof(uint32_t). This CL fixes it. BUG=252492 ==========
LGTM
Description was changed from ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because a denominator in the calculation is wrong sizeof(uint32_t*). This should have been sizeof(uint32_t). This CL fixes it. BUG=252492 ========== to ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because a denominator sizeof(uint32_t*) in the calculation is not correct. This should have been sizeof(uint32_t). This CL fixes it. BUG=252492 ==========
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because a denominator sizeof(uint32_t*) in the calculation is not correct. This should have been sizeof(uint32_t). This CL fixes it. BUG=252492 ========== to ========== Worker: Fix wrong stack size calculation Before this CL, stack size for worker threads is unexpectedly lowered than the intended size (500KB) because a denominator sizeof(uint32_t*) in the calculation is not correct. This should have been sizeof(uint32_t). This CL fixes it. BUG=252492 Committed: https://crrev.com/7d9e75c30702cd9e0e206ebac8906b56389565dc Cr-Commit-Position: refs/heads/master@{#432267} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7d9e75c30702cd9e0e206ebac8906b56389565dc Cr-Commit-Position: refs/heads/master@{#432267} |