Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2506473004:
Fixed rotation anchoring while using a document.rootScroller. (Closed)
DescriptionFixed rotation anchoring while using a document.rootScroller.
Removes assumption in RotationViewportAnchor that the FrameView is the layout
viewport.
BUG=505516
Committed: https://crrev.com/08374111ede77c0a1537a0c958df295a5a97faf9
Cr-Commit-Position: refs/heads/master@{#433058}
Patch Set 1 #Patch Set 2 : Nits #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Rebase #Patch Set 6 : Rebase #
Depends on Patchset: Messages
Total messages: 38 (31 generated)
The CQ bit was checked by bokan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bokan@chromium.org
The CQ bit was checked by bokan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by bokan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fixed rotation anchoring while using a document.rootScroller. Removes assumption in RotationViewportAnchor that the FrameView is the layout viewport. BUG=505516 ========== to ========== Fixed rotation anchoring while using a document.rootScroller. Removes assumption in RotationViewportAnchor that the FrameView is the layout viewport. BUG=505516 ==========
bokan@chromium.org changed reviewers: + skobes@chromium.org
Another document.rootScroller patch. ptal.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
lgtm
The CQ bit was checked by bokan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by bokan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL) cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by bokan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bokan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org Link to the patchset: https://codereview.chromium.org/2506473004/#ps100001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bokan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fixed rotation anchoring while using a document.rootScroller. Removes assumption in RotationViewportAnchor that the FrameView is the layout viewport. BUG=505516 ========== to ========== Fixed rotation anchoring while using a document.rootScroller. Removes assumption in RotationViewportAnchor that the FrameView is the layout viewport. BUG=505516 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Fixed rotation anchoring while using a document.rootScroller. Removes assumption in RotationViewportAnchor that the FrameView is the layout viewport. BUG=505516 ========== to ========== Fixed rotation anchoring while using a document.rootScroller. Removes assumption in RotationViewportAnchor that the FrameView is the layout viewport. BUG=505516 Committed: https://crrev.com/08374111ede77c0a1537a0c958df295a5a97faf9 Cr-Commit-Position: refs/heads/master@{#433058} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/08374111ede77c0a1537a0c958df295a5a97faf9 Cr-Commit-Position: refs/heads/master@{#433058} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
