Fixed rotation anchoring while using a document.rootScroller.

third_party/WebKit/Source/web/RotationViewportAnchor.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "web/RotationViewportAnchor.h"
 
 #include "core/dom/ContainerNode.h"
 #include "core/dom/Node.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 87 matching lines @@
 
 RotationViewportAnchor::~RotationViewportAnchor() {
   restoreToAnchor();
 }
 
 void RotationViewportAnchor::setAnchor() {
   RootFrameViewport* rootFrameViewport =
       m_rootFrameView->getRootFrameViewport();
   DCHECK(rootFrameViewport);
 
-  IntRect outerViewRect =
-      layoutViewport().visibleContentRect(IncludeScrollbars);
-  IntRect innerViewRect = rootFrameViewport->visibleContentRect();
-
   m_oldPageScaleFactor = m_visualViewport->scale();
   m_oldMinimumPageScaleFactor =
       m_pageScaleConstraintsSet.finalConstraints().minimumScale;
 
   // Save the absolute location in case we won't find the anchor node, we'll
   // fall back to that.
   m_visualViewportInDocument =
       FloatPoint(rootFrameViewport->visibleContentRect().location());
 
   m_anchorNode.clear();
   m_anchorNodeBounds = LayoutRect();
   m_anchorInNodeCoords = FloatSize();
   m_normalizedVisualViewportOffset = FloatSize();
 
-  if (innerViewRect.isEmpty())
+  IntRect innerViewRect = rootFrameViewport->visibleContentRect();
+
+  // Preserve origins at the absolute screen origin.
+  if (innerViewRect.location() == IntPoint::zero() || innerViewRect.isEmpty())
     return;
 
-  // Preserve origins at the absolute screen origin
-  if (innerViewRect.location() == IntPoint::zero())
-    return;
-
-  // Inner rectangle should be within the outer one.
-  DCHECK(outerViewRect.contains(innerViewRect));
-
-  // Outer rectangle is used as a scale, we need positive width and height.
-  DCHECK(!outerViewRect.isEmpty());
-
-  m_normalizedVisualViewportOffset =
-      FloatSize(innerViewRect.location() - outerViewRect.location());
+  IntRect outerViewRect =
+      layoutViewport().visibleContentRect(IncludeScrollbars);
 
   // Normalize by the size of the outer rect
+  DCHECK(!outerViewRect.isEmpty());
+  m_normalizedVisualViewportOffset = m_visualViewport->scrollOffset();
   m_normalizedVisualViewportOffset.scale(1.0 / outerViewRect.width(),
                                          1.0 / outerViewRect.height());
 
-  FloatPoint anchorOffset(innerViewRect.size());
+  // Note, we specifically use the unscaled visual viewport size here as the
+  // conversion into content-space below will apply the scale.
+  FloatPoint anchorOffset(m_visualViewport->size());
   anchorOffset.scale(m_anchorInInnerViewCoords.width(),
                      m_anchorInInnerViewCoords.height());
 
-  const FloatPoint anchorPointInContents = m_rootFrameView->rootFrameToContents(
+  // Note, we specifically convert to the rootFrameView contents here, rather
+  // than the layout viewport. That's because hit testing works from the
+  // FrameView's content coordinates even if it's not the layout viewport.
+  const FloatPoint anchorPointInContents = m_rootFrameView->frameToContents(
       m_visualViewport->viewportToRootFrame(anchorOffset));
 
   Node* node = findNonEmptyAnchorNode(flooredIntPoint(anchorPointInContents),
                                       innerViewRect,
                                       m_rootFrameView->frame().eventHandler());
   if (!node)
     return;
 
   m_anchorNode = node;
   m_anchorNodeBounds = node->boundingBox();
@@ skipping 86 matching lines @@
       anchorOffsetFromNode;
 
   // Compute the new origin point relative to the new anchor point
   FloatSize anchorOffsetFromOrigin = innerSize;
   anchorOffsetFromOrigin.scale(m_anchorInInnerViewCoords.width(),
                                m_anchorInInnerViewCoords.height());
   return anchorPoint - anchorOffsetFromOrigin;
 }
 
 }  // namespace blink