DevTools: remove Bindings.NetworkMapping.addMapping/removeMapping methods

DevTools: remove Bindings.NetworkMapping.addMapping/removeMapping methods

This patch removes fileSystemMapping from Bindings.NetworkMapping. As a
result, the fileSystemMapping starts to listen to FileSystemAdded/FileSystemRemoved
events by itself.

BUG=649837
R=dgozman

Committed: https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b
Cr-Commit-Position: refs/heads/master@{#432252}

[lushnikov, 2016-11-15 00:04:27]

please, take a look

[lushnikov, 2016-11-15 00:04:31]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 00:05:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-11-15 00:25:07]

Description was changed from

==========
DevTools: remove Bingins.NetworkMapping.addMapping/removeMapping methods

This patch removes fileSystemMapping from Bindings.NetworkMapping. As a
result, the fileSystemMapping starts to listen to
FileSystemAdded/FileSystemRemoved
events by itself.

BUG=649837
R=dgozman
==========

to

==========
DevTools: remove Bindings.NetworkMapping.addMapping/removeMapping methods

This patch removes fileSystemMapping from Bindings.NetworkMapping. As a
result, the fileSystemMapping starts to listen to
FileSystemAdded/FileSystemRemoved
events by itself.

BUG=649837
R=dgozman
==========

[dgozman, 2016-11-15 00:31:30]

lgtm

[lushnikov, 2016-11-15 00:33:51]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-11-15 00:33:51]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-11-15 00:34:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 01:53:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 01:53:02]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-11-15 02:48:53]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-11-15 02:49:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 04:17:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 04:17:22]

Failed to apply patch for
third_party/WebKit/Source/devtools/front_end/main/Main.js:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/devtools/front_end/main/Main.js:180
  error: third_party/WebKit/Source/devtools/front_end/main/Main.js: patch does
not apply

Patch:       third_party/WebKit/Source/devtools/front_end/main/Main.js
Index: third_party/WebKit/Source/devtools/front_end/main/Main.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/Main.js
b/third_party/WebKit/Source/devtools/front_end/main/Main.js
index
3d7cac61e224c638ad0453354162770b2b4ab182..ad03bb71a67a4f9775b697a156d6def507040875
100644
--- a/third_party/WebKit/Source/devtools/front_end/main/Main.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/Main.js
@@ -180,12 +180,11 @@ Main.Main = class {
     Workspace.fileManager = new Workspace.FileManager();
     Workspace.workspace = new Workspace.Workspace();
     Common.formatterWorkerPool = new Common.FormatterWorkerPool();
-    Workspace.fileSystemMapping = new Workspace.FileSystemMapping();
+    Workspace.fileSystemMapping = new
Workspace.FileSystemMapping(Workspace.isolatedFileSystemManager);
 
     var fileSystemWorkspaceBinding =
         new
Bindings.FileSystemWorkspaceBinding(Workspace.isolatedFileSystemManager,
Workspace.workspace);
-    Bindings.networkMapping = new Bindings.NetworkMapping(
-        SDK.targetManager, Workspace.workspace, fileSystemWorkspaceBinding,
Workspace.fileSystemMapping);
+    Bindings.networkMapping = new Bindings.NetworkMapping(Workspace.workspace);
     Main.networkProjectManager =
         new Bindings.NetworkProjectManager(SDK.targetManager,
Workspace.workspace);
     Bindings.presentationConsoleMessageHelper =

[lushnikov, 2016-11-15 18:38:54]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-11-15 18:38:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2506463002/#ps20001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-11-15 18:39:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 20:53:12]

Description was changed from

==========
DevTools: remove Bindings.NetworkMapping.addMapping/removeMapping methods

This patch removes fileSystemMapping from Bindings.NetworkMapping. As a
result, the fileSystemMapping starts to listen to
FileSystemAdded/FileSystemRemoved
events by itself.

BUG=649837
R=dgozman
==========

to

==========
DevTools: remove Bindings.NetworkMapping.addMapping/removeMapping methods

This patch removes fileSystemMapping from Bindings.NetworkMapping. As a
result, the fileSystemMapping starts to listen to
FileSystemAdded/FileSystemRemoved
events by itself.

BUG=649837
R=dgozman
==========

[commit-bot: I haz the power, 2016-11-15 20:53:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 20:55:59]

Description was changed from

==========
DevTools: remove Bindings.NetworkMapping.addMapping/removeMapping methods

This patch removes fileSystemMapping from Bindings.NetworkMapping. As a
result, the fileSystemMapping starts to listen to
FileSystemAdded/FileSystemRemoved
events by itself.

BUG=649837
R=dgozman
==========

to

==========
DevTools: remove Bindings.NetworkMapping.addMapping/removeMapping methods

This patch removes fileSystemMapping from Bindings.NetworkMapping. As a
result, the fileSystemMapping starts to listen to
FileSystemAdded/FileSystemRemoved
events by itself.

BUG=649837
R=dgozman

Committed: https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b
Cr-Commit-Position: refs/heads/master@{#432252}
==========

[commit-bot: I haz the power, 2016-11-15 20:56:00]

Patchset 2 (id:??) landed as
https://crrev.com/c7500edf7716fe6af09e4462edbe8dfc7c1e524b
Cr-Commit-Position: refs/heads/master@{#432252}