Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/WebKit/LayoutTests/inspector/file-system-mapping-overrides.html

Issue 2506463002: DevTools: remove Bindings.NetworkMapping.addMapping/removeMapping methods (Closed)
Patch Set: rebaseline Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/file-system-mapping-overrides.html
diff --git a/third_party/WebKit/LayoutTests/inspector/file-system-mapping-overrides.html b/third_party/WebKit/LayoutTests/inspector/file-system-mapping-overrides.html
index 772b5ccdf5643f32edf55b601ea8006e629ad5fb..ac50e1a440e8574c77f01b76f0554c045fb21ab8 100644
--- a/third_party/WebKit/LayoutTests/inspector/file-system-mapping-overrides.html
+++ b/third_party/WebKit/LayoutTests/inspector/file-system-mapping-overrides.html
@@ -7,49 +7,53 @@ function test()
InspectorTest.runTestSuite([
function testFileSystemClashDirectOrder(next)
{
- var fileSystemMapping = new Workspace.FileSystemMapping();
+ var fileSystemMapping = new Workspace.FileSystemMapping(Workspace.isolatedFileSystemManager);
fileSystemMapping.addFileSystem("file:///Source/devtools");
fileSystemMapping.addNonConfigurableFileMapping("file:///Source/devtools", "chrome-devtools://devtools/bundled/wrong_url", "/");
fileSystemMapping.addFileMapping("file:///Source/devtools", "http://localhost:1234/right_url", "/");
InspectorTest.addResult(fileSystemMapping.networkURLForFileSystemURL("file:///Source/devtools", "file:///Source/devtools/file.txt"));
+ fileSystemMapping.dispose();
next();
},
function testFileSystemClashReversedOrder(next)
{
- var fileSystemMapping = new Workspace.FileSystemMapping();
+ var fileSystemMapping = new Workspace.FileSystemMapping(Workspace.isolatedFileSystemManager);
fileSystemMapping.addFileSystem("file:///Source/devtools");
fileSystemMapping.addFileMapping("file:///Source/devtools", "http://localhost:1234/right_url", "/");
fileSystemMapping.addNonConfigurableFileMapping("file:///Source/devtools", "chrome-devtools://devtools/wrong_url", "/");
InspectorTest.addResult(fileSystemMapping.networkURLForFileSystemURL("file:///Source/devtools", "file:///Source/devtools/file.txt"));
+ fileSystemMapping.dispose();
next();
},
function testNetworkClashDirectOrder(next)
{
- var fileSystemMapping = new Workspace.FileSystemMapping();
+ var fileSystemMapping = new Workspace.FileSystemMapping(Workspace.isolatedFileSystemManager);
fileSystemMapping.addFileSystem("file:///Source/devtools");
fileSystemMapping.addNonConfigurableFileMapping("file:///Source/devtools", "http://localhost:1234/front_end", "/wrong");
fileSystemMapping.addFileMapping("file:///Source/devtools", "http://localhost:1234/front_end", "/right");
InspectorTest.addResult(fileSystemMapping.fileForURL("http://localhost:1234/front_end/file.txt").fileURL);
+ fileSystemMapping.dispose();
next();
},
function testNetworkClashReversedOrder(next)
{
- var fileSystemMapping = new Workspace.FileSystemMapping();
+ var fileSystemMapping = new Workspace.FileSystemMapping(Workspace.isolatedFileSystemManager);
fileSystemMapping.addFileSystem("file:///Source/devtools");
fileSystemMapping.addFileMapping("file:///Source/devtools", "http://localhost:1234/front_end", "/right");
fileSystemMapping.addNonConfigurableFileMapping("file:///Source/devtools", "http://localhost:1234/front_end", "/wrong");
InspectorTest.addResult(fileSystemMapping.fileForURL("http://localhost:1234/front_end/file.txt").fileURL);
+ fileSystemMapping.dispose();
next();
},
]);

Powered by Google App Engine
This is Rietveld 408576698