Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2506393004: binding: Makes non-cross-origin-accessible attrs be accessor props. (Closed)

Created:
4 years, 1 month ago by Yuki
Modified:
4 years ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Makes non-cross-origin-accessible attrs be accessor props. Makes non-cross-origin accessible attributes be accessor properties. [CachedAccessor] already made window.document an accessor property, and this CL doesn't affect it. Cross-origin accessible attributes remain being data properties. The previous attempt was http://crrev.com/1380503002 BUG=475556 Committed: https://crrev.com/5b2adfa4d4e2fb6b74d177625605dcece20a40b7 Cr-Commit-Position: refs/heads/master@{#434942}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Updated a test expectation. #

Patch Set 4 : Updated a test expectation. #

Patch Set 5 : Synced. #

Patch Set 6 : Updated a test expectation. #

Patch Set 7 : Synced. #

Patch Set 8 : Updated a test expectation. #

Patch Set 9 : Synced. #

Patch Set 10 : Updated a test expectation. #

Patch Set 11 : Added [ NeedsRebaseline ] in TestExpectations. #

Patch Set 12 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1058 lines, -647 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLInputElement/input-slider-update-styled-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/replaceable.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/replaceable-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-clone-deep-array-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/css-insert-import-rule-twice-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/lenient-this.html View 1 1 chunk +49 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/global-constructors-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/dom/location-stringify.html View 1 1 chunk +15 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/cross-origin-access-over-property-descriptor.html View 1 1 chunk +23 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/cross-origin-access-over-property-descriptor-expected.txt View 1 1 chunk +13 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/interfaces-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/browsers/the-window-object/window-properties-expected.txt View 1 1 chunk +93 lines, -93 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/webstorage/idlharness-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/HTMLHeadElement/textInHead1-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/HTMLHeadElement/textInHead2-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/HTMLHeadElement/textInHead3-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/Range/surroundContents-1-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/clone-contents-0-end-offset-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/css-rule-functions-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/importNodeHTML-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/importNodeXML-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/inner-text-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/dom/scroll-reveal-top-overflow-expected.png View 1 2 3 4 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 4 chunks +268 lines, -142 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 8 9 4 chunks +268 lines, -142 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +275 lines, -147 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_attributes.py View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 12 chunks +29 lines, -52 lines 0 comments Download

Messages

Total messages: 67 (56 generated)
Yuki
Could you review this CL? This is another try to make Window and Location's attributes ...
4 years, 1 month ago (2016-11-18 14:31:10 UTC) #6
haraken
LGTM to try.
4 years, 1 month ago (2016-11-18 15:53:44 UTC) #9
Yuki
+R=tkent@, Could you review as an owner of gloabl-interface-listing things? We're going to make second ...
4 years, 1 month ago (2016-11-21 13:34:59 UTC) #21
tkent
lgtm
4 years, 1 month ago (2016-11-21 14:13:25 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506393004/180001
4 years ago (2016-11-28 09:47:34 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/339226)
4 years ago (2016-11-28 12:09:22 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506393004/180001
4 years ago (2016-11-28 12:15:32 UTC) #50
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/339314)
4 years ago (2016-11-28 15:08:50 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506393004/220001
4 years ago (2016-11-29 08:31:23 UTC) #62
commit-bot: I haz the power
Committed patchset #12 (id:220001)
4 years ago (2016-11-29 09:52:16 UTC) #65
commit-bot: I haz the power
4 years ago (2016-11-29 09:54:09 UTC) #67
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/5b2adfa4d4e2fb6b74d177625605dcece20a40b7
Cr-Commit-Position: refs/heads/master@{#434942}

Powered by Google App Engine
This is Rietveld 408576698