third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp - Issue 2506393004: binding: Makes non-cross-origin-accessible attrs be accessor props.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2506393004: binding: Makes non-cross-origin-accessible attrs be accessor props. (Closed)

Patch Set: Synced. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/Source/bindings/scripts/v8_attributes.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

index 2288a3c237461e3f882fcdcf57b08f6a97e2ce01..70f3293c83182cacd79ceca9f8c3eca49c390726 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

@@ -65,7 +65,7 @@

namespace blink {

void V8Window::eventAttributeGetterCustom(

- const v8::PropertyCallbackInfo<v8::Value>& info) {

+ const v8::FunctionCallbackInfo<v8::Value>& info) {

LocalDOMWindow* impl = toLocalDOMWindow(V8Window::toImpl(info.Holder()));

ExceptionState exceptionState(ExceptionState::GetterContext, "event",

"Window", info.Holder(), info.GetIsolate());

@@ -92,7 +92,7 @@ void V8Window::eventAttributeGetterCustom(

void V8Window::eventAttributeSetterCustom(

v8::Local<v8::Value> value,

- const v8::PropertyCallbackInfo<void>& info) {

+ const v8::FunctionCallbackInfo<v8::Value>& info) {

LocalDOMWindow* impl = toLocalDOMWindow(V8Window::toImpl(info.Holder()));

ExceptionState exceptionState(ExceptionState::SetterContext, "event",

"Window", info.Holder(), info.GetIsolate());

@@ -115,7 +115,7 @@ void V8Window::eventAttributeSetterCustom(

}

void V8Window::frameElementAttributeGetterCustom(

- const v8::PropertyCallbackInfo<v8::Value>& info) {

+ const v8::FunctionCallbackInfo<v8::Value>& info) {

LocalDOMWindow* impl = toLocalDOMWindow(V8Window::toImpl(info.Holder()));

if (!BindingSecurity::shouldAllowAccessTo(