Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2506373006: [TTS][Overlay] Update fix to overflowing the narrow panel. (Closed)

Created:
4 years, 1 month ago by Donn Denman
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[TTS][Overlay] Update fix to overflowing the narrow panel. A previous fix just checked if the height changed, but looks like there's a split-window case that needs to check if the width changes. Now checking if either changes. BUG=632483 Review-Url: https://codereview.chromium.org/2504703002 Cr-Commit-Position: refs/heads/master@{#432405} (cherry picked from commit ea64b4bb0f8733eca15c998be8b7634c87f32728) Committed: https://chromium.googlesource.com/chromium/src/+/3c589e40897eaf1fd83b38a93e867d51fb4ad05f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Donn Denman
4 years, 1 month ago (2016-11-19 02:00:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c589e40897eaf1fd83b38a93e867d51fb4ad05f.

Powered by Google App Engine
This is Rietveld 408576698