Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2504703002: [TTS][Overlay] Update fix to overflowing the narrow panel. (Closed)

Created:
4 years, 1 month ago by Donn Denman
Modified:
4 years, 1 month ago
Reviewers:
mdjones
CC:
chromium-reviews, mdjones+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS][Overlay] Update fix to overflowing the narrow panel. A previous fix just checked if the height changed, but looks like there's a split-window case that needs to check if the width changes. Now checking if either changes. BUG=632483 Committed: https://crrev.com/ea64b4bb0f8733eca15c998be8b7634c87f32728 Cr-Commit-Position: refs/heads/master@{#432405}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated the comment to include multi-window. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java View 1 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Donn Denman
Matt, PTAL when convenient.
4 years, 1 month ago (2016-11-16 01:15:42 UTC) #6
mdjones
lgtm % updated comment https://codereview.chromium.org/2504703002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java (right): https://codereview.chromium.org/2504703002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java#newcode812 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:812: // viewport width or height. ...
4 years, 1 month ago (2016-11-16 01:20:19 UTC) #7
Donn Denman
Thanks Matt! https://codereview.chromium.org/2504703002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java (right): https://codereview.chromium.org/2504703002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java#newcode812 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:812: // viewport width or height. On 2016/11/16 ...
4 years, 1 month ago (2016-11-16 01:26:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504703002/20001
4 years, 1 month ago (2016-11-16 01:27:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 06:42:23 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 06:48:43 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea64b4bb0f8733eca15c998be8b7634c87f32728
Cr-Commit-Position: refs/heads/master@{#432405}

Powered by Google App Engine
This is Rietveld 408576698