Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: chrome/browser/resources/settings/system_page/system_page.html

Issue 2506323002: MD Settings: show an extension-controlled-indicator for proxy (Closed)
Patch Set: -@private Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
3 <link rel="import" href="/controls/controlled_button.html"> 3 <link rel="import" href="/controls/controlled_button.html">
4 <link rel="import" href="/controls/extension_controlled_indicator.html">
4 <link rel="import" href="/controls/settings_checkbox.html"> 5 <link rel="import" href="/controls/settings_checkbox.html">
5 <link rel="import" href="/lifetime_browser_proxy.html"> 6 <link rel="import" href="/lifetime_browser_proxy.html">
6 <link rel="import" href="/prefs/prefs.html"> 7 <link rel="import" href="/prefs/prefs.html">
7 <link rel="import" href="/settings_shared_css.html"> 8 <link rel="import" href="/settings_shared_css.html">
8 <link rel="import" href="/system_page/system_page_browser_proxy.html"> 9 <link rel="import" href="/system_page/system_page_browser_proxy.html">
9 10
10 <dom-module id="settings-system-page"> 11 <dom-module id="settings-system-page">
11 <template> 12 <template>
12 <style include="settings-shared"> 13 <style include="settings-shared">
13 /* TODO(dbeam): is it worth generalizing this style? Does something like 14 /* TODO(dbeam): is it worth generalizing this style? Does something like
14 * this already exist (buttons after a checkbox in the same row)? */ 15 * this already exist (buttons after a checkbox in the same row)? */
15 #hardware-acceleration { 16 #hardware-acceleration {
16 align-items: center; 17 align-items: center;
17 display: flex; 18 display: flex;
18 } 19 }
19 20
20 #hardware-acceleration settings-checkbox { 21 #hardware-acceleration settings-checkbox {
21 flex: 1; 22 flex: 1;
22 } 23 }
24
25 .proxy-wrapper {
26 align-items: center;
27 display: flex;
28 min-height: inherit;
29 }
30
31 extension-controlled-indicator {
32 width: 100%;
33 }
23 </style> 34 </style>
24 <div class="settings-box block first"> 35 <div class="settings-box block first">
25 <if expr="not is_macosx"> 36 <if expr="not is_macosx">
26 <settings-checkbox label="$i18n{backgroundAppsLabel}" 37 <settings-checkbox label="$i18n{backgroundAppsLabel}"
27 pref="{{prefs.background_mode.enabled}}"> 38 pref="{{prefs.background_mode.enabled}}">
28 </settings-checkbox> 39 </settings-checkbox>
29 </if> 40 </if>
30 <div id="hardware-acceleration"> 41 <div id="hardware-acceleration">
31 <settings-checkbox label="$i18n{hardwareAccelerationLabel}" 42 <settings-checkbox label="$i18n{hardwareAccelerationLabel}"
32 pref="{{prefs.hardware_acceleration_mode.enabled}}"> 43 pref="{{prefs.hardware_acceleration_mode.enabled}}">
33 </settings-checkbox> 44 </settings-checkbox>
34 <template is="dom-if" if="[[shouldShowRestart_( 45 <template is="dom-if" if="[[shouldShowRestart_(
35 prefs.hardware_acceleration_mode.enabled.value)]]"> 46 prefs.hardware_acceleration_mode.enabled.value)]]">
36 <paper-button on-tap="onRestartTap_">$i18n{restart}</paper-button> 47 <paper-button on-tap="onRestartTap_">$i18n{restart}</paper-button>
37 </template> 48 </template>
38 </div> 49 </div>
39 </div> 50 </div>
40 <div class="settings-box"> 51 <div class="settings-box block">
41 <controlled-button class="primary-button" pref="[[prefs.proxy]]" 52 <div class="proxy-wrapper">
42 on-tap="onChangeProxySettingsTap_"> 53 <controlled-button class="primary-button" pref="[[prefs.proxy]]"
43 $i18n{changeProxySettings} 54 on-tap="onChangeProxySettingsTap_">
44 </controlled-button> 55 $i18n{changeProxySettings}
56 </controlled-button>
57 </div>
58 <template is="dom-if" if="[[prefs.proxy.extensionId]]">
59 <div class="proxy-wrapper">
60 <extension-controlled-indicator
61 extension-id="[[prefs.proxy.extensionId]]"
62 extension-name="[[prefs.proxy.controlledByName]]"
63 extension-can-be-disabled="[[prefs.proxy.extensionCanBeDisabled]]"
64 on-extension-disable="onExtensionDisable_">
65 </extension-controlled-indicator>
66 </div>
67 </template>
45 </div> 68 </div>
46 </template> 69 </template>
47 <script src="/system_page/system_page.js"></script> 70 <script src="/system_page/system_page.js"></script>
48 </dom-module> 71 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698