Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2506263003: Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (Closed)

Created:
4 years, 1 month ago by the real yoland
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts. (patchset #2 id:140001 of https://codereview.chromium.org/2506013004/ ) Reason for revert: This CL cause WebView to crash BUG=666193 Original issue's description: > Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts. > > Reverted in: > https://codereview.chromium.org/2507153002/ > > Reason for reland: > Now explicitly lists default toolchain > > Also modify java_assertion_enabler to resolve cycle dependency issue > and empty jar issue. > > TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@chromium.org > BUG=462676, 665157, 665478 > > Committed: https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e > Cr-Commit-Position: refs/heads/master@{#432607} TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@chromium.org,zpeng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462676, 665157, 665478 Committed: https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca Cr-Commit-Position: refs/heads/master@{#432789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -141 lines) Patch
M BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M build/android/java_assertion_enabler/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M build/android/java_assertion_enabler/java/org/chromium/javaassertionenabler/AssertionEnabler.java View 3 chunks +28 lines, -55 lines 0 comments Download
M build/config/android/internal_rules.gni View 8 chunks +37 lines, -77 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 1 chunk +1 line, -2 lines 0 comments Download
M media/midi/java/src/org/chromium/midi/MidiManagerAndroid.java View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/ow2_asm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
the real yoland
Created Revert of Add GN build rules to allow java_assertion_enabler to enable Java asserts.
4 years, 1 month ago (2016-11-17 06:53:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506263003/1
4 years, 1 month ago (2016-11-17 06:54:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 06:55:09 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5e5387276fc07873f2a2c730b7b1adbd0d0a70ca Cr-Commit-Position: refs/heads/master@{#432789}
4 years, 1 month ago (2016-11-17 06:56:47 UTC) #7
F
4 years, 1 month ago (2016-11-21 16:34:07 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2517203002/ by zpeng@chromium.org.

The reason for reverting is: Will update when fixed.

Powered by Google App Engine
This is Rietveld 408576698