Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: content/browser/renderer_host/render_widget_helper.h

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_helper.h
diff --git a/content/browser/renderer_host/render_widget_helper.h b/content/browser/renderer_host/render_widget_helper.h
index f8d456f88ed37719efaa900b56b486082aa36f9d..c663f974ee5f43c29c194f87af8554c3321832c6 100644
--- a/content/browser/renderer_host/render_widget_helper.h
+++ b/content/browser/renderer_host/render_widget_helper.h
@@ -90,8 +90,7 @@ class RenderWidgetHelper
void CreateNewWindow(mojom::CreateNewWindowParamsPtr params,
bool no_javascript_access,
- base::ProcessHandle render_process,
- int32_t* route_id,
+ int32_t* render_view_route_id,
int32_t* main_frame_route_id,
int32_t* main_frame_widget_route_id,
SessionStorageNamespace* session_storage_namespace);
@@ -108,11 +107,12 @@ class RenderWidgetHelper
~RenderWidgetHelper();
// Called on the UI thread to finish creating a window.
- void OnCreateWindowOnUI(mojom::CreateNewWindowParamsPtr params,
- int32_t route_id,
- int32_t main_frame_route_id,
- int32_t main_frame_widget_route_id,
- SessionStorageNamespace* session_storage_namespace);
+ void OnCreateNewWindowOnUI(
+ mojom::CreateNewWindowParamsPtr params,
+ int32_t render_view_route_id,
+ int32_t main_frame_route_id,
+ int32_t main_frame_widget_route_id,
+ SessionStorageNamespace* session_storage_namespace);
// Called on the UI thread to finish creating a widget.
void OnCreateWidgetOnUI(int32_t opener_id,
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/renderer_host/render_widget_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698