Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 2506183002: Make window.open() IPCs be frame-based (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index c71f07aaf44339895cff508d92f3544546c9355c..cf28e72665362c4af02ea3c362b7e57b62f166a9 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -757,7 +757,6 @@ bool RenderViewHostImpl::OnMessageReceived(const IPC::Message& msg) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(RenderViewHostImpl, msg)
IPC_MESSAGE_HANDLER(FrameHostMsg_RenderProcessGone, OnRenderProcessGone)
- IPC_MESSAGE_HANDLER(ViewHostMsg_ShowView, OnShowView)
IPC_MESSAGE_HANDLER(ViewHostMsg_ShowWidget, OnShowWidget)
IPC_MESSAGE_HANDLER(ViewHostMsg_ShowFullscreenWidget,
OnShowFullscreenWidget)
@@ -798,22 +797,6 @@ void RenderViewHostImpl::ShutdownAndDestroy() {
delete this;
}
-void RenderViewHostImpl::CreateNewWindow(
- int32_t route_id,
- int32_t main_frame_route_id,
- int32_t main_frame_widget_route_id,
- const mojom::CreateNewWindowParams& params,
- SessionStorageNamespace* session_storage_namespace) {
- mojom::CreateNewWindowParamsPtr validated_params(params.Clone());
- GetProcess()->FilterURL(false, &validated_params->target_url);
- GetProcess()->FilterURL(false, &validated_params->opener_url);
- GetProcess()->FilterURL(true, &validated_params->opener_security_origin);
-
- delegate_->CreateNewWindow(GetSiteInstance(), route_id, main_frame_route_id,
- main_frame_widget_route_id, *validated_params,
- session_storage_namespace);
-}
-
void RenderViewHostImpl::CreateNewWidget(int32_t route_id,
blink::WebPopupType popup_type) {
delegate_->CreateNewWidget(GetProcess()->GetID(), route_id, popup_type);
@@ -823,15 +806,6 @@ void RenderViewHostImpl::CreateNewFullscreenWidget(int32_t route_id) {
delegate_->CreateNewFullscreenWidget(GetProcess()->GetID(), route_id);
}
-void RenderViewHostImpl::OnShowView(int route_id,
- WindowOpenDisposition disposition,
- const gfx::Rect& initial_rect,
- bool user_gesture) {
- delegate_->ShowCreatedWindow(GetProcess()->GetID(), route_id, disposition,
- initial_rect, user_gesture);
- Send(new ViewMsg_Move_ACK(route_id));
-}
-
void RenderViewHostImpl::OnShowWidget(int route_id,
const gfx::Rect& initial_rect) {
delegate_->ShowCreatedWidget(GetProcess()->GetID(), route_id, initial_rect);
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/renderer_host/render_widget_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698