Make window.open() IPCs be frame-based

content/browser/frame_host/interstitial_page_impl.cc

Index: content/browser/frame_host/interstitial_page_impl.cc
diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc
index 1c3e782e5ae2d2745ec5111478a3468494f49239..9d77e9d387c1b843cac9aeff2f6689ac485b2b8b 100644
--- a/content/browser/frame_host/interstitial_page_impl.cc
+++ b/content/browser/frame_host/interstitial_page_impl.cc
@@ -730,23 +730,23 @@ void InterstitialPageImpl::DontCreateViewForTesting() {
 
 void InterstitialPageImpl::CreateNewWindow(
     SiteInstance* source_site_instance,
-    int32_t route_id,
+    int32_t render_view_route_id,
     int32_t main_frame_route_id,
     int32_t main_frame_widget_route_id,
     const mojom::CreateNewWindowParams& params,
     SessionStorageNamespace* session_storage_namespace) {
-  NOTREACHED() << "InterstitialPage does not support showing popups yet.";
+  NOTIMPLEMENTED() << "InterstitialPage does not support showing popups.";
 }
 
 void InterstitialPageImpl::CreateNewWidget(int32_t render_process_id,
                                            int32_t route_id,
                                            blink::WebPopupType popup_type) {
-  NOTREACHED() << "InterstitialPage does not support showing drop-downs yet.";
+  NOTIMPLEMENTED() << "InterstitialPage does not support showing drop-downs.";
 }
 
 void InterstitialPageImpl::CreateNewFullscreenWidget(int32_t render_process_id,
                                                      int32_t route_id) {
-  NOTREACHED()
+  NOTIMPLEMENTED()
       << "InterstitialPage does not support showing full screen popups.";
 }
 
@@ -755,18 +755,18 @@ void InterstitialPageImpl::ShowCreatedWindow(int process_id,
                                              WindowOpenDisposition disposition,
                                              const gfx::Rect& initial_rect,
                                              bool user_gesture) {
-  NOTREACHED() << "InterstitialPage does not support showing popups yet.";
+  NOTIMPLEMENTED() << "InterstitialPage does not support showing popups.";
 }
 
 void InterstitialPageImpl::ShowCreatedWidget(int process_id,
                                              int route_id,
                                              const gfx::Rect& initial_rect) {
-  NOTREACHED() << "InterstitialPage does not support showing drop-downs yet.";
+  NOTIMPLEMENTED() << "InterstitialPage does not support showing drop-downs.";
 }
 
 void InterstitialPageImpl::ShowCreatedFullscreenWidget(int process_id,
                                                        int route_id) {
-  NOTREACHED()
+  NOTIMPLEMENTED()
       << "InterstitialPage does not support showing full screen popups.";

[Avi (use Gerrit), 2016/12/12 19:17:05]

I would argue that interstitial pages never should be doing these things, so
this should stay as NOTREACHED but still drop the "yet" from the descriptions.

Just me tho.

[ncarter (slow), 2016/12/15 00:33:16]

Done.

 }