Make window.open() IPCs be frame-based

content/browser/frame_host/interstitial_page_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/interstitial_page_impl.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 712 matching lines @@
 InterstitialPageDelegate* InterstitialPageImpl::GetDelegateForTesting() {
   return delegate_.get();
 }
 
 void InterstitialPageImpl::DontCreateViewForTesting() {
   create_view_ = false;
 }
 
 void InterstitialPageImpl::CreateNewWindow(
     SiteInstance* source_site_instance,
-    int32_t route_id,
+    int32_t render_view_route_id,
     int32_t main_frame_route_id,
     int32_t main_frame_widget_route_id,
     const mojom::CreateNewWindowParams& params,
     SessionStorageNamespace* session_storage_namespace) {
-  NOTREACHED() << "InterstitialPage does not support showing popups yet.";
+  NOTIMPLEMENTED() << "InterstitialPage does not support showing popups.";
 }
 
 void InterstitialPageImpl::CreateNewWidget(int32_t render_process_id,
                                            int32_t route_id,
                                            blink::WebPopupType popup_type) {
-  NOTREACHED() << "InterstitialPage does not support showing drop-downs yet.";
+  NOTIMPLEMENTED() << "InterstitialPage does not support showing drop-downs.";
 }
 
 void InterstitialPageImpl::CreateNewFullscreenWidget(int32_t render_process_id,
                                                      int32_t route_id) {
-  NOTREACHED()
+  NOTIMPLEMENTED()
       << "InterstitialPage does not support showing full screen popups.";
 }
 
 void InterstitialPageImpl::ShowCreatedWindow(int process_id,
                                              int route_id,
                                              WindowOpenDisposition disposition,
                                              const gfx::Rect& initial_rect,
                                              bool user_gesture) {
-  NOTREACHED() << "InterstitialPage does not support showing popups yet.";
+  NOTIMPLEMENTED() << "InterstitialPage does not support showing popups.";
 }
 
 void InterstitialPageImpl::ShowCreatedWidget(int process_id,
                                              int route_id,
                                              const gfx::Rect& initial_rect) {
-  NOTREACHED() << "InterstitialPage does not support showing drop-downs yet.";
+  NOTIMPLEMENTED() << "InterstitialPage does not support showing drop-downs.";
 }
 
 void InterstitialPageImpl::ShowCreatedFullscreenWidget(int process_id,
                                                        int route_id) {
-  NOTREACHED()
+  NOTIMPLEMENTED()
       << "InterstitialPage does not support showing full screen popups.";

[Avi (use Gerrit), 2016/12/12 19:17:05]

I would argue that interstitial pages never should be doing these things, so
this should stay as NOTREACHED but still drop the "yet" from the descriptions.

Just me tho.

[ncarter (slow), 2016/12/15 00:33:16]

Done.

 }
 
 SessionStorageNamespace* InterstitialPageImpl::GetSessionStorageNamespace(
     SiteInstance* instance) {
   return session_storage_namespace_.get();
 }
 
 FrameTree* InterstitialPageImpl::GetFrameTree() {
   return &frame_tree_;
 }
@@ skipping 171 matching lines @@
 void InterstitialPageImpl::UpdateDeviceScaleFactor(double device_scale_factor) {
   WebContentsImpl* web_contents_impl =
       static_cast<WebContentsImpl*>(web_contents_);
   if (!web_contents_impl)
     return;
 
   web_contents_impl->UpdateDeviceScaleFactor(device_scale_factor);
 }
 
 }  // namespace content