Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2506103002:
[Offline Pages] Fix test harness not using default policy. (Closed)
|
Created:
4 years, 1 month ago by romax Modified:
4 years, 1 month ago CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Offline Pages] Fix test harness not using default policy.
Fixed the issue where the test harness was not using the values in default
policy, which would not be easy to track and lead to unexpected results.
BUG=665990
Committed: https://crrev.com/602bcbadf2fb102ab8dfcb4f73bda1afa2fa606a
Cr-Commit-Position: refs/heads/master@{#433312}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Removing useless customized budget. #Messages
Total messages: 21 (10 generated)
romax@chromium.org changed reviewers: + dougarnett@chromium.org
PTAL!
The CQ bit was checked by romax@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm - with one rename comment https://codereview.chromium.org/2506103002/diff/1/chrome/browser/android/offl... File chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc (right): https://codereview.chromium.org/2506103002/diff/1/chrome/browser/android/offl... chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc:177: kImmediateRequestExpirationTimeInSeconds)); I was confused by this name - consider something like kImmediateProcessingTimeBudgetSeconds instead
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
Removed customized budget. I don't think it's necessary for the test and it probably shouldn't be used when testing.
lgtm
romax@chromium.org changed reviewers: + petewil@chromium.org
Pete may I get a quick OWNER's approval plz. Thanks!
lgtm
The CQ bit was checked by romax@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was checked by romax@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Offline Pages] Fix test harness not using default policy. Fixed the issue where the test harness was not using the values in default policy, which would not be easy to track and lead to unexpected results. BUG=665990 ========== to ========== [Offline Pages] Fix test harness not using default policy. Fixed the issue where the test harness was not using the values in default policy, which would not be easy to track and lead to unexpected results. BUG=665990 Committed: https://crrev.com/602bcbadf2fb102ab8dfcb4f73bda1afa2fa606a Cr-Commit-Position: refs/heads/master@{#433312} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/602bcbadf2fb102ab8dfcb4f73bda1afa2fa606a Cr-Commit-Position: refs/heads/master@{#433312} |
