[Offline Pages] Fix test harness not using default policy.

chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h"
 
 #include "base/android/callback_android.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
@@ skipping 29 matching lines @@
 using base::android::ConvertJavaStringToUTF8;
 using base::android::ConvertUTF8ToJavaString;
 using base::android::JavaParamRef;
 using base::android::ScopedJavaGlobalRef;
 using base::android::ScopedJavaLocalRef;
 
 namespace offline_pages {
 namespace android {
 
 namespace {
-const bool kPreferUntriedRequest = false;
-const bool kPreferEarlierRequest = true;
-const bool kPreferRetryCountOverRecency = false;
-const int kMaxStartedTries = 4;
-const int kMaxCompletedTries = 1;
 const int kImmediateRequestExpirationTimeInSeconds = 3600;
 
 void ToJavaOfflinePageList(JNIEnv* env,
                            jobject j_result_obj,
                            const std::vector<OfflinePageItem>& offline_pages) {
   for (const OfflinePageItem& offline_page : offline_pages) {
     Java_OfflinePageEvaluationBridge_createOfflinePageAndAddToList(
         env, j_result_obj,
         ConvertUTF8ToJavaString(env, offline_page.url.spec()),
         offline_page.offline_id,
@@ skipping 100 matching lines @@
 bool OfflinePageEvaluationBridge::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 // static
 std::unique_ptr<KeyedService>
 OfflinePageEvaluationBridge::GetTestingRequestCoordinator(
     content::BrowserContext* context) {
   // Create a new OfflinerPolicy with a larger background processing
   // budget (3600 sec). Other values are the same with default ones.
+  OfflinerPolicy default_policy;
   std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy(
-      kPreferUntriedRequest, kPreferEarlierRequest,
-      kPreferRetryCountOverRecency, kMaxStartedTries, kMaxCompletedTries,
+      default_policy.ShouldPreferUntriedRequests(),
+      default_policy.ShouldPreferEarlierRequests(),
+      default_policy.RetryCountIsMoreImportantThanRecency(),
+      default_policy.GetMaxStartedTries(),
+      default_policy.GetMaxCompletedTries(),
       kImmediateRequestExpirationTimeInSeconds));

[dougarnett, 2016/11/16 20:16:42]

I was confused by this name - consider something like
kImmediateProcessingTimeBudgetSeconds instead

   std::unique_ptr<OfflinerFactory> prerenderer_offliner(
       new PrerenderingOfflinerFactory(context));
 
   scoped_refptr<base::SequencedTaskRunner> background_task_runner =
       content::BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(
           content::BrowserThread::GetBlockingPool()->GetSequenceToken());
   Profile* profile = Profile::FromBrowserContext(context);
   base::FilePath queue_store_path =
       profile->GetPath().Append(chrome::kOfflinePageRequestQueueDirname);
 
@@ skipping 150 matching lines @@
 
 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const {
   if (!offline_page_model_->is_loaded())
     return;
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_);
 }
 
 }  // namespace android
 }  // namespace offline_pages