Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2506093004: Protect base/numerics against change in intmax_t's underlying type (Closed)

Created:
4 years, 1 month ago by jschuh
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Protect base/numerics against change in intmax_t's underlying type Adds a static_assert to catch if this ever changes, because that will require changing some type promotion logic and other assumptions. TBR=tsepez@chromium.org Committed: https://crrev.com/beed850c4d92e005d1514a7f859259f5d0767dd1 Cr-Commit-Position: refs/heads/master@{#433085}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/numerics/safe_math_impl.h View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506093004/1
4 years, 1 month ago (2016-11-17 16:54:42 UTC) #2
Tom Sepez
https://codereview.chromium.org/2506093004/diff/1/base/numerics/safe_math_impl.h File base/numerics/safe_math_impl.h (right): https://codereview.chromium.org/2506093004/diff/1/base/numerics/safe_math_impl.h#newcode60 base/numerics/safe_math_impl.h:60: static_assert(sizeof(uintmax_t) == 8, nit: Do you want a <= ...
4 years, 1 month ago (2016-11-17 17:04:55 UTC) #3
jschuh
https://codereview.chromium.org/2506093004/diff/1/base/numerics/safe_math_impl.h File base/numerics/safe_math_impl.h (right): https://codereview.chromium.org/2506093004/diff/1/base/numerics/safe_math_impl.h#newcode60 base/numerics/safe_math_impl.h:60: static_assert(sizeof(uintmax_t) == 8, On 2016/11/17 17:04:54, Tom Sepez wrote: ...
4 years, 1 month ago (2016-11-17 18:06:46 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/237017) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-17 18:59:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506093004/1
4 years, 1 month ago (2016-11-17 19:10:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/264496)
4 years, 1 month ago (2016-11-17 21:29:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506093004/1
4 years, 1 month ago (2016-11-17 21:44:32 UTC) #12
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-17 23:51:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/264666)
4 years, 1 month ago (2016-11-18 00:24:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506093004/1
4 years, 1 month ago (2016-11-18 01:20:15 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 04:08:58 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 04:12:39 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/beed850c4d92e005d1514a7f859259f5d0767dd1
Cr-Commit-Position: refs/heads/master@{#433085}

Powered by Google App Engine
This is Rietveld 408576698