Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2506043002: Allow ImageBitmap objects to be created from placeholder canvases. (Closed)

Created:
4 years, 1 month ago by Justin Novosad
Modified:
4 years, 1 month ago
Reviewers:
xidachen, xlai (Olivia)
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow ImageBitmap objects to be created from placeholder canvases. BUG=665057 Committed: https://crrev.com/801e2543a028cdf1da7b656a6a11f95c7b1eb573 Cr-Commit-Position: refs/heads/master@{#432623}

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-placeholder-createImageBitmap.html View 1 1 chunk +45 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Justin Novosad
PTAL
4 years, 1 month ago (2016-11-16 18:47:44 UTC) #3
xidachen
lgtm
4 years, 1 month ago (2016-11-16 18:52:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506043002/20001
4 years, 1 month ago (2016-11-16 18:58:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 20:53:55 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 21:00:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/801e2543a028cdf1da7b656a6a11f95c7b1eb573
Cr-Commit-Position: refs/heads/master@{#432623}

Powered by Google App Engine
This is Rietveld 408576698