Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2506033003: Move list-style-position to be generated in ComputedStyleBase (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index 31573b94f4585262fd459c213041aa2e6016af2b..9f7310a2f5c75c3f559ebaad6452c546a093cc59 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -215,7 +215,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
inline bool compareEqualNonIndependent(const InheritedData& other) const {
return (m_listStyleType == other.m_listStyleType) &&
- (m_listStylePosition == other.m_listStylePosition) &&
(m_textAlign == other.m_textAlign) &&
(m_textTransform == other.m_textTransform) &&
(m_hasSimpleUnderline == other.m_hasSimpleUnderline) &&
@@ -231,7 +230,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
}
unsigned m_listStyleType : 7; // EListStyleType
- unsigned m_listStylePosition : 1; // EListStylePosition
unsigned m_textAlign : 4; // ETextAlign
unsigned m_textTransform : 2; // ETextTransform
unsigned m_hasSimpleUnderline : 1; // True if 'underline solid' is the only
@@ -363,8 +361,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
ComputedStyleBase::setBitDefaults();
m_inheritedData.m_listStyleType =
static_cast<unsigned>(initialListStyleType());
- m_inheritedData.m_listStylePosition =
- static_cast<unsigned>(initialListStylePosition());
m_inheritedData.m_textAlign = static_cast<unsigned>(initialTextAlign());
m_inheritedData.m_textTransform =
static_cast<unsigned>(initialTextTransform());
@@ -2129,17 +2125,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
m_inheritedData.m_listStyleType = static_cast<unsigned>(v);
}
- // list-style-position
- static EListStylePosition initialListStylePosition() {
- return EListStylePosition::Outside;
- }
- EListStylePosition listStylePosition() const {
- return static_cast<EListStylePosition>(m_inheritedData.m_listStylePosition);
- }
- void setListStylePosition(EListStylePosition v) {
- m_inheritedData.m_listStylePosition = static_cast<unsigned>(v);
- }
-
// list-style-image
static StyleImage* initialListStyleImage() { return 0; }
StyleImage* listStyleImage() const;
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSProperties.in ('k') | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698