third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 2506033003: Move list-style-position to be generated in ComputedStyleBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2506033003: Move list-style-position to be generated in ComputedStyleBase (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index c45ebe126090d8488234a29ce3e6f6f678725ff6..a88aa09eb673ebed99c822e09b94e6bea910bead 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -870,8 +870,7 @@ bool ComputedStyle::diffNeedsFullLayoutAndPaintInvalidation(

} else if (display() == EDisplay::ListItem) {

if (m_inheritedData.m_listStyleType !=

other.m_inheritedData.m_listStyleType ||

- m_inheritedData.m_listStylePosition !=

- other.m_inheritedData.m_listStylePosition)

+ listStylePosition() != other.listStylePosition())

return true;

}