Move list-style-position to be generated in ComputedStyleBase

Move list-style-position to be generated in ComputedStyleBase

Move the inherited property list-style-position and its enum,
EListStylePosition, to be generated in ComputedStyleBase.

BUG=628043
Committed: https://crrev.com/af7430f8e9a58ad90cc5b5153a650862b4d19a87
Cr-Commit-Position: refs/heads/master@{#434115}

[sashab, 2016-11-17 05:02:14]

sashab@chromium.org changed reviewers:
+ bugsnash@chromium.org

[sashab, 2016-11-21 03:31:13]

sashab@chromium.org changed reviewers:
+ meade@chromium.org
- bugsnash@chromium.org

[sashab, 2016-11-21 03:31:13]

-bugsnash who is on leave

+meade who just got back :) welcome back! hahaha

[sashab, 2016-11-21 03:39:17]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 03:39:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 03:41:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 03:41:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[meade_UTC10, 2016-11-21 04:28:42]

lgtm

It looks like you need to sync, but otherwise \o/

[sashab, 2016-11-21 04:29:13]

Haha wow look at that red tree! Sorry about that. Thanks eddy :)

[sashab, 2016-11-21 04:37:25]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-11-21 04:37:26]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2506033003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-21 04:37:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 06:40:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 06:40:53]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2016-11-22 02:40:36]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-11-22 02:40:36]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2506033003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-22 02:41:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 04:31:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 04:31:43]

Failed to apply patch for third_party/WebKit/Source/core/style/ComputedStyle.h:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/core/style/ComputedStyle.h:363
  error: third_party/WebKit/Source/core/style/ComputedStyle.h: patch does not
apply

Patch:       third_party/WebKit/Source/core/style/ComputedStyle.h
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h
b/third_party/WebKit/Source/core/style/ComputedStyle.h
index
dc7f23d61b54a35324c0e935bac9e9d41ad7b8be..ce389477a000894a53cc13d44207be2a3d20d083
100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -215,7 +215,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
 
     inline bool compareEqualNonIndependent(const InheritedData& other) const {
       return (m_listStyleType == other.m_listStyleType) &&
-             (m_listStylePosition == other.m_listStylePosition) &&
              (m_textAlign == other.m_textAlign) &&
              (m_textTransform == other.m_textTransform) &&
              (m_hasSimpleUnderline == other.m_hasSimpleUnderline) &&
@@ -231,7 +230,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
     }
 
     unsigned m_listStyleType : 7;      // EListStyleType
-    unsigned m_listStylePosition : 1;  // EListStylePosition
     unsigned m_textAlign : 4;          // ETextAlign
     unsigned m_textTransform : 2;      // ETextTransform
     unsigned m_hasSimpleUnderline : 1;  // True if 'underline solid' is the
only
@@ -363,8 +361,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
     ComputedStyleBase::setBitDefaults();
     m_inheritedData.m_listStyleType =
         static_cast<unsigned>(initialListStyleType());
-    m_inheritedData.m_listStylePosition =
-        static_cast<unsigned>(initialListStylePosition());
     m_inheritedData.m_textAlign = static_cast<unsigned>(initialTextAlign());
     m_inheritedData.m_textTransform = initialTextTransform();
     m_inheritedData.m_hasSimpleUnderline = false;
@@ -2127,17 +2123,6 @@ class CORE_EXPORT ComputedStyle : public
ComputedStyleBase,
     m_inheritedData.m_listStyleType = static_cast<unsigned>(v);
   }
 
-  // list-style-position
-  static EListStylePosition initialListStylePosition() {
-    return EListStylePosition::Outside;
-  }
-  EListStylePosition listStylePosition() const {
-    return
static_cast<EListStylePosition>(m_inheritedData.m_listStylePosition);
-  }
-  void setListStylePosition(EListStylePosition v) {
-    m_inheritedData.m_listStylePosition = static_cast<unsigned>(v);
-  }
-
   // list-style-image
   static StyleImage* initialListStyleImage() { return 0; }
   StyleImage* listStyleImage() const;

[sashab, 2016-11-23 02:59:55]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-11-23 02:59:55]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2506033003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-23 03:00:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 04:29:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479869995358020,
"parent_rev": "b54fa47df94c5e7596dd330340bace886293ddbc", "commit_rev":
"a438aa98ec0d97eb93ae8fc15467cb1a54540e83"}

[commit-bot: I haz the power, 2016-11-23 04:30:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-23 04:31:54]

Description was changed from

==========
Move list-style-position to be generated in ComputedStyleBase

Move the inherited property list-style-position and its enum,
EListStylePosition, to be generated in ComputedStyleBase.

BUG=628043
==========

to

==========
Move list-style-position to be generated in ComputedStyleBase

Move the inherited property list-style-position and its enum,
EListStylePosition, to be generated in ComputedStyleBase.

BUG=628043

Committed: https://crrev.com/af7430f8e9a58ad90cc5b5153a650862b4d19a87
Cr-Commit-Position: refs/heads/master@{#434115}
==========

[commit-bot: I haz the power, 2016-11-23 04:31:55]

Patchset 4 (id:??) landed as
https://crrev.com/af7430f8e9a58ad90cc5b5153a650862b4d19a87
Cr-Commit-Position: refs/heads/master@{#434115}