Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts.

Reland of Add GN build rules to allow java_assertion_enabler to enable Java asserts.

Reverted in:
https://codereview.chromium.org/2507153002/

Reason for reland:
Now explicitly lists default toolchain

Also modify java_assertion_enabler to resolve cycle dependency issue
and empty jar issue.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@chromium.org
BUG=462676, 665157, 665478
Committed: https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
Cr-Commit-Position: refs/heads/master@{#432607}

[F, 2016-11-16 18:28:44]

Created Reland of Add GN build rules to allow java_assertion_enabler to enable
Java asserts.

[F, 2016-11-16 18:40:56]

Description was changed from

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts. (patchset #1 id:1 of https://codereview.chromium.org/2507153002/ )

Reason for revert:
will update when fixed.

Original issue's description:
> Revert of Add GN build rules to allow java_assertion_enabler to enable Java
asserts. (patchset #4 id:60001 of https://codereview.chromium.org/2497043002/ )
> 
> Reason for revert:
> Broke arm64 builder:
>
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM...
> 
> Original issue's description:
> > Add GN build rules to allow java_assertion_enabler to enable Java asserts.
> > 
> > Also modify java_assertion_enabler to resolve cycle dependency issue
> > and empty jar issue.
> > 
> > BUG=462676,665157,665478
> > 
> > Committed: https://crrev.com/5d3328f05a88be232e11d2ce34bffa64ca2362a5
> > Cr-Commit-Position: refs/heads/master@{#432521}
> 
>
TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=462676,665157,665478

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462676,665157,665478
==========

to

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted in:
https://codereview.chromium.org/2507153002/

Reason for reland:
Now explicitly lists default toolchain

Also modify java_assertion_enabler to resolve cycle dependency issue
and empty jar issue.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=462676,665157,665478
==========

[agrieve, 2016-11-16 18:43:00]

On 2016/11/16 18:28:44, F wrote:
> Created Reland of Add GN build rules to allow java_assertion_enabler to enable
> Java asserts.

lgtm

[F, 2016-11-16 18:43:11]

The CQ bit was checked by zpeng@chromium.org

[commit-bot: I haz the power, 2016-11-16 18:44:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 20:19:11]

Description was changed from

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted in:
https://codereview.chromium.org/2507153002/

Reason for reland:
Now explicitly lists default toolchain

Also modify java_assertion_enabler to resolve cycle dependency issue
and empty jar issue.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=462676,665157,665478
==========

to

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted in:
https://codereview.chromium.org/2507153002/

Reason for reland:
Now explicitly lists default toolchain

Also modify java_assertion_enabler to resolve cycle dependency issue
and empty jar issue.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=462676,665157,665478
==========

[commit-bot: I haz the power, 2016-11-16 20:19:12]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2016-11-16 20:25:09]

Description was changed from

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted in:
https://codereview.chromium.org/2507153002/

Reason for reland:
Now explicitly lists default toolchain

Also modify java_assertion_enabler to resolve cycle dependency issue
and empty jar issue.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=462676,665157,665478
==========

to

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted in:
https://codereview.chromium.org/2507153002/

Reason for reland:
Now explicitly lists default toolchain

Also modify java_assertion_enabler to resolve cycle dependency issue
and empty jar issue.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=462676,665157,665478

Committed: https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
Cr-Commit-Position: refs/heads/master@{#432607}
==========

[commit-bot: I haz the power, 2016-11-16 20:25:10]

Patchset 2 (id:??) landed as
https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
Cr-Commit-Position: refs/heads/master@{#432607}

[Lei Zhang, 2016-11-17 06:04:46]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-11-17 06:04:47]

I think this red bot, [1] along with the other red webview bots are caused by
this CL.

[1]
https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20M%...

[Lei Zhang, 2016-11-17 06:06:02]

Description was changed from

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted in:
https://codereview.chromium.org/2507153002/

Reason for reland:
Now explicitly lists default toolchain

Also modify java_assertion_enabler to resolve cycle dependency issue
and empty jar issue.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=462676,665157,665478

Committed: https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
Cr-Commit-Position: refs/heads/master@{#432607}
==========

to

==========
Reland of Add GN build rules to allow java_assertion_enabler to enable Java
asserts.

Reverted in:
https://codereview.chromium.org/2507153002/

Reason for reland:
Now explicitly lists default toolchain

Also modify java_assertion_enabler to resolve cycle dependency issue
and empty jar issue.

TBR=jbudorick@chromium.org,agrieve@chromium.org,toyoshim@chromium.org,qinmin@...
BUG=462676,665157,665478

Committed: https://crrev.com/95785a8601992a057837bc189e9f7eba61701f1e
Cr-Commit-Position: refs/heads/master@{#432607}
==========

[Lei Zhang, 2016-11-17 06:06:02]

thestig@chromium.org changed reviewers:
- thestig@chromium.org

[Lei Zhang, 2016-11-17 06:12:32]

On 2016/11/17 06:04:47, Lei Zhang (Mostly OOO) wrote:
> I think this red bot, [1] along with the other red webview bots are caused by
> this CL.
> 
> [1]
>
https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20M%...

Someone else already filed a bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=666193

[the real yoland, 2016-11-17 06:52:48]

On 2016/11/17 at 06:12:32, thestig wrote:
> On 2016/11/17 06:04:47, Lei Zhang (Mostly OOO) wrote:
> > I think this red bot, [1] along with the other red webview bots are caused
by
> > this CL.
> > 
> > [1]
> >
https://build.chromium.org/p/chromium.android/builders/Android%20Webview%20M%...
> 
> Someone else already filed a bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=666193

Just confirmed this is the reason, WebView builds crash after this CL as shown
in https://bugs.chromium.org/p/chromium/issues/detail?id=666193

[the real yoland, 2016-11-17 06:53:39]

A revert of this CL (patchset #2 id:140001) has been created in
https://codereview.chromium.org/2506263003/ by yolandyan@chromium.org.

The reason for reverting is: This CL cause WebView to crash

BUG=666193.

[kamree888, 2016-11-18 13:11:54]

kamree888@gmail.com changed reviewers:
+ kamree888@gmail.com

[kamree888, 2016-11-18 13:11:54]

lgtm