Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 2505943003: Rename positionNewFloats() to placeNewFloats(). (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename positionNewFloats() to placeNewFloats(). This will distinguish it better from the method named "positionAndLayoutFloat". Also be explicit about the fact that we use the top margin edge when positioning floats, as opposed to the top border edge, which is common for all other object types. So "logicalTop" usually means the logical top of the border edge. Therefore, use "logicalTopMarginEdge" for floats. No behavioral changes, just cleanup. BUG=663942 Committed: https://crrev.com/7892652d84a2a704b5a6118806886720dc8c7127 Cr-Commit-Position: refs/heads/master@{#432895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -40 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 10 chunks +27 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutBlockFlow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBreaker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineWidth.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-11-17 14:25:56 UTC) #6
szager1
lgtm
4 years, 1 month ago (2016-11-17 15:48:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505943003/1
4 years, 1 month ago (2016-11-17 16:42:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 16:49:13 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 16:52:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7892652d84a2a704b5a6118806886720dc8c7127
Cr-Commit-Position: refs/heads/master@{#432895}

Powered by Google App Engine
This is Rietveld 408576698