Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 2505853004: Let lowestFloatLogicalBottom() take EClear instead of FloatingObject::Type (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
index 9fac2d753b52a00a85b96d728ea592998046011a..74f29edad8bde349bf967d9b5e093c3fada4ab17 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
@@ -379,6 +379,8 @@ class CORE_EXPORT LayoutBlockFlow : public LayoutBlock {
LayoutUnit lowestFloatLogicalBottom(
szager1 2016/11/16 22:35:35 You should be able to eliminate this method by pro
mstensho (USE GERRIT) 2016/11/16 22:45:37 Indeed! Looks like I didn't bother to check if the
FloatingObject::Type = FloatingObject::FloatLeftRight) const;
+ LayoutUnit lowestFloatLogicalBottom(EClear) const;
+
bool hasOverhangingFloats() const {
return parent() && containsFloats() &&
lowestFloatLogicalBottom() > logicalHeight();
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698