Refactor SharedFunctionInfo::IsBuiltin.

Refactor SharedFunctionInfo::IsBuiltin.

This method is a slight misnomer. What we actually want to know is
whether the function was defined in a user-provided script.

Also remove redundant Script::hide_source flag.

R=bmeurer@chromium.org, ulan@chromium.org

Committed: https://crrev.com/45cb0fc7b83e05f031640386e0242c04d74aa88c
Cr-Commit-Position: refs/heads/master@{#41065}

[Benedikt Meurer, 2016-11-16 09:19:48]

LGTM, thanks.

[Yang, 2016-11-16 09:20:04]

On 2016/11/16 09:18:25, Yang wrote:

Ulan, please take a look at src/heap. Benedikt, the rest, please.

[Yang, 2016-11-16 09:20:24]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 09:20:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2016-11-16 09:33:38]

heap lgtm

[commit-bot: I haz the power, 2016-11-16 09:48:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 09:48:34]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-11-16 14:01:32]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-11-16 14:01:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 14:04:22]

Committed patchset #1 (id:1)

[Michael Achenbach, 2016-11-16 19:47:43]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2512463002/ by machenbach@chromium.org.

The reason for reverting is: Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[Yang, 2016-11-17 06:15:50]

Description was changed from

==========
Refactor SharedFunctionInfo::IsBuiltin.

This method is a slight misnomer. What we actually want to know is
whether the function was defined in a user-provided script.

Also remove redundant Script::hide_source flag.

R=bmeurer@chromium.org, ulan@chromium.org
==========

to

==========
Refactor SharedFunctionInfo::IsBuiltin.

This method is a slight misnomer. What we actually want to know is
whether the function was defined in a user-provided script.

Also remove redundant Script::hide_source flag.

R=bmeurer@chromium.org, ulan@chromium.org
==========

[Yang, 2016-11-17 09:11:48]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 09:11:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 09:39:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 09:39:27]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-11-17 09:40:10]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-11-17 09:40:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2505853003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-17 09:40:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 09:42:44]

Description was changed from

==========
Refactor SharedFunctionInfo::IsBuiltin.

This method is a slight misnomer. What we actually want to know is
whether the function was defined in a user-provided script.

Also remove redundant Script::hide_source flag.

R=bmeurer@chromium.org, ulan@chromium.org
==========

to

==========
Refactor SharedFunctionInfo::IsBuiltin.

This method is a slight misnomer. What we actually want to know is
whether the function was defined in a user-provided script.

Also remove redundant Script::hide_source flag.

R=bmeurer@chromium.org, ulan@chromium.org
==========

[commit-bot: I haz the power, 2016-11-17 09:42:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:36:21]

Description was changed from

==========
Refactor SharedFunctionInfo::IsBuiltin.

This method is a slight misnomer. What we actually want to know is
whether the function was defined in a user-provided script.

Also remove redundant Script::hide_source flag.

R=bmeurer@chromium.org, ulan@chromium.org
==========

to

==========
Refactor SharedFunctionInfo::IsBuiltin.

This method is a slight misnomer. What we actually want to know is
whether the function was defined in a user-provided script.

Also remove redundant Script::hide_source flag.

R=bmeurer@chromium.org, ulan@chromium.org

Committed: https://crrev.com/f21a6b259be518787a3caebc4654b882a6016400
Cr-Commit-Position: refs/heads/master@{#41036}
==========

[commit-bot: I haz the power, 2016-11-17 22:36:22]

Patchset 2 (id:??) landed as
https://crrev.com/f21a6b259be518787a3caebc4654b882a6016400
Cr-Commit-Position: refs/heads/master@{#41036}

[commit-bot: I haz the power, 2016-11-17 22:37:47]

Description was changed from

==========
Refactor SharedFunctionInfo::IsBuiltin.

This method is a slight misnomer. What we actually want to know is
whether the function was defined in a user-provided script.

Also remove redundant Script::hide_source flag.

R=bmeurer@chromium.org, ulan@chromium.org

Committed: https://crrev.com/f21a6b259be518787a3caebc4654b882a6016400
Cr-Commit-Position: refs/heads/master@{#41036}
==========

to

==========
Refactor SharedFunctionInfo::IsBuiltin.

This method is a slight misnomer. What we actually want to know is
whether the function was defined in a user-provided script.

Also remove redundant Script::hide_source flag.

R=bmeurer@chromium.org, ulan@chromium.org

Committed: https://crrev.com/45cb0fc7b83e05f031640386e0242c04d74aa88c
Cr-Commit-Position: refs/heads/master@{#41065}
==========

[commit-bot: I haz the power, 2016-11-17 22:37:48]

Patchset 2 (id:??) landed as
https://crrev.com/45cb0fc7b83e05f031640386e0242c04d74aa88c
Cr-Commit-Position: refs/heads/master@{#41065}