src/objects.cc - Issue 2505853003: Refactor SharedFunctionInfo::IsBuiltin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 2505853003: Refactor SharedFunctionInfo::IsBuiltin. (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index ee31a367cd6590f70c5b05bec9b9fcdecd218fba..89d8c75ca0e02dec4e4ede8079ffa150ba079d6a 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -13301,8 +13301,7 @@ Handle<String> JSFunction::ToString(Handle<JSFunction> function) {

Handle<SharedFunctionInfo> shared_info(function->shared(), isolate);

// Check if {function} should hide its source code.

- if (!shared_info->script()->IsScript() ||

- Script::cast(shared_info->script())->hide_source()) {

+ if (!shared_info->IsUserJavaScript()) {

return NativeCodeFunctionSourceString(shared_info);

}

« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »