Remove the confusing certificate revocation checkbox.

Remove the confusing certificate revocation checkbox.

BUG=361820
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269005

[palmer, 2014-04-24 18:15:32]

PTAL.

[agl, 2014-04-24 18:18:14]

LGTM for the principle, but I don't know the code sufficiently well to know if
there are other bits that need tweaking too.

[Ryan Sleevi, 2014-04-24 18:21:11]

How do you plan to handle users who have enabled it? Now there is no way to
turn it off.
On Apr 24, 2014 11:15 AM, <palmer@chromium.org> wrote:

> Reviewers: felt, agl, Ryan Sleevi,
>
> Message:
> PTAL.
>
> Description:
> Remove the confusing certificate revocation checkbox.
>
> BUG=361820
>
> Please review this at https://codereview.chromium.org/250583004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+0, -11 lines):
>   M chrome/app/generated_resources.grd
>   M chrome/browser/resources/options/browser_options.html
>   M chrome/browser/ui/webui/options/browser_options_handler.cc
>
>
> Index: chrome/app/generated_resources.grd
> diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_
> resources.grd
> index 49690659aedbda82d73a452a19e807e8c8bbf638..
> 6518abb4a50038b3265d17bb5ef2c0fe479bb7d7 100644
> --- a/chrome/app/generated_resources.grd
> +++ b/chrome/app/generated_resources.grd
> @@ -10205,9 +10205,6 @@ Would you like to start <ph
> name="CONTROL_PANEL_APPLET_NAME">$1<ex>Add/Remove Pr
>          <message name="IDS_OPTIONS_SAFEBROWSING_ENABLEDOWNLOADFEEDBACK"
> desc="Checkbox label: should Chrome upload suspicious downloads to Safe
> Browsing">
>            Send suspicious downloaded files to Google
>          </message>
> -        <message name="IDS_OPTIONS_SSL_CHECKREVOCATION" desc="The label
> of the 'Check for server certificate revocation' checkbox">
> -          Check for server certificate revocation
> -        </message>
>
>          <if expr="chromeos">
>            <message name="IDS_OPTIONS_FACTORY_RESET" desc="Name of the
> factory reset option on the chrome settings page">
> Index: chrome/browser/resources/options/browser_options.html
> diff --git a/chrome/browser/resources/options/browser_options.html
> b/chrome/browser/resources/options/browser_options.html
> index 4cea7dcb5e0ea476eecce45e9e1c6f5fac56e001..
> 690aa64ec0ecaa4b146b0f36ec78113a051e4f2b 100644
> --- a/chrome/browser/resources/options/browser_options.html
> +++ b/chrome/browser/resources/options/browser_options.html
> @@ -652,13 +652,6 @@
>                i18n-content="certificatesManageButton"></button>
>          </div>
>  </if>
> -        <div class="checkbox">
> -          <label>
> -            <input id="sslCheckRevocation" pref="ssl.rev_checking.
> enabled"
> -                   type="checkbox">
> -            <span i18n-content="sslCheckRevocation"></span>
> -          </label>
> -        </div>
>        </div>
>    </section>
>  <if expr="enable_service_discovery">
> Index: chrome/browser/ui/webui/options/browser_options_handler.cc
> diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc
> b/chrome/browser/ui/webui/options/browser_options_handler.cc
> index beeb8d5a92c6259dfff26f00b72bedf78ba2da2d..
> 71a8caf54737d5a7db66f6d2dc56cec20d26126d 100644
> --- a/chrome/browser/ui/webui/options/browser_options_handler.cc
> +++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
> @@ -302,7 +302,6 @@ void
BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue*
> values) {
>      { "startupRestoreLastSession", IDS_OPTIONS_STARTUP_RESTORE_LAST_SESSION
> },
>      { "settingsTitle", IDS_SETTINGS_TITLE },
>      { "showAdvancedSettings", IDS_SETTINGS_SHOW_ADVANCED_SETTINGS },
> -    { "sslCheckRevocation", IDS_OPTIONS_SSL_CHECKREVOCATION },
>      { "startupSetPages", IDS_OPTIONS_STARTUP_SET_PAGES },
>      { "startupShowNewTab", IDS_OPTIONS_STARTUP_SHOW_NEWTAB },
>      { "startupShowPages", IDS_OPTIONS_STARTUP_SHOW_PAGES },
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[agl, 2014-04-24 18:23:52]

On Thu, Apr 24, 2014 at 11:21 AM, Ryan Sleevi <rsleevi@chromium.org> wrote:
> How do you plan to handle users who have enabled it? Now there is no way to
> turn it off.

I thought we were going to support it by group policy only, no? So I
was assuming a followup patch would ignore the setting if in the
config file.


Cheers

AGL

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[palmer, 2014-04-24 18:38:24]

> > How do you plan to handle users who have enabled it? Now there is no way to
> > turn it off.
> 
> I thought we were going to support it by group policy only, no? So I
> was assuming a followup patch would ignore the setting if in the
> config file.

Oh yeah, I had code to ignore the setting, but then reverted it when I figured
out we need to keep the enterprise option. I'll add ignoring the setting unless
it was set by enterprise policy to this CL; I think they should go in together.

[palmer, 2014-04-28 21:46:02]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2014-04-28 21:47:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/palmer@chromium.org/250583004/20001

[commit-bot: I haz the power, 2014-04-28 22:42:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 22:42:36]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[palmer, 2014-04-28 23:13:57]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2014-04-28 23:14:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/palmer@chromium.org/250583004/20001

[commit-bot: I haz the power, 2014-04-28 23:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 23:33:37]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[palmer, 2014-04-29 00:42:38]

+estade as an OWNER for chrome/browser/ui/webui/options. PTAL, thanks!

[palmer, 2014-05-06 22:41:39]

Ping, estade. :) Or should I ask someone else? Thanks!

[palmer, 2014-05-07 20:36:06]

It seems I forgot to actually add estade as a reviewer. :) estade or dbeam,
could you please take a look? Thanks!

[Evan Stade, 2014-05-08 00:32:10]

*/options/* lgtm

[palmer, 2014-05-08 00:46:16]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2014-05-08 00:50:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/palmer@chromium.org/250583004/20001

[commit-bot: I haz the power, 2014-05-08 00:58:35]

Change committed as 269005