chrome/browser/net/ssl_config_service_manager_pref.cc - Issue 250583004: Remove the confusing certificate revocation checkbox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/ssl_config_service_manager_pref.cc

Issue 250583004: Remove the confusing certificate revocation checkbox. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Set rev_checking_enabled = false unless set by enterprise policy. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/ssl_config_service_manager_pref.cc

diff --git a/chrome/browser/net/ssl_config_service_manager_pref.cc b/chrome/browser/net/ssl_config_service_manager_pref.cc

index 9c61f9545b98fc2c3f5cc232e93385a710fbf244..8af3c749905c7b58fc597fd88cd72c2a941cc559 100644

--- a/chrome/browser/net/ssl_config_service_manager_pref.cc

+++ b/chrome/browser/net/ssl_config_service_manager_pref.cc

@@ -265,7 +265,12 @@ void SSLConfigServiceManagerPref::OnPreferenceChanged(

void SSLConfigServiceManagerPref::GetSSLConfigFromPrefs(

net::SSLConfig* config) {

- config->rev_checking_enabled = rev_checking_enabled_.GetValue();

+ // rev_checking_enabled was formerly a user-settable preference, but now

+ // it is managed-only.

+ if (rev_checking_enabled_.IsManaged())

+ config->rev_checking_enabled = rev_checking_enabled_.GetValue();

+ else

+ config->rev_checking_enabled = false;

config->rev_checking_required_local_anchors =

rev_checking_required_local_anchors_.GetValue();

std::string version_min_str = ssl_version_min_.GetValue();