Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2505813002:
[runtime stats] Fix crash after r41001 (Closed)
Description[runtime stats] Fix crash after r41001
The timer can be missing in the timers stack when RCS is started dynamically.
BUG=chromium:665659
TBR=cbruni@chromium.org
Committed: https://crrev.com/ca3f487979324c92f86e3ce88e8be9ac8579ecaa
Cr-Commit-Position: refs/heads/master@{#41049}
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
alph@chromium.org changed reviewers: + cbruni@chromium.org, fmeawad@chromium.org
Could you please take a look. Also I'd like to ask you to add me to your RCS related patches as DevTools do now depend on RCS. Thanks!
Message was sent while issue was closed.
Description was changed from ========== [runtime stats] Fix crash after r41001 The timer can be missing in the timers stack when RCS is started dynamically. BUG=chromium:665659 ========== to ========== [runtime stats] Fix crash after r41001 The timer can be missing in the timers stack when RCS is started dynamically. BUG=chromium:665659 ==========
Message was sent while issue was closed.
fmeawad@chromium.org changed reviewers: + lpy@chromium.org
Message was sent while issue was closed.
On 2016/11/16 00:40:30, alph wrote: > Could you please take a look. > > Also I'd like to ask you to add me to your RCS related patches as DevTools do > now depend on RCS. Thanks! lpy can you check that cl?
On 2016/11/16 00:45:21, fmeawad wrote: > On 2016/11/16 00:40:30, alph wrote: > > Could you please take a look. > > > > Also I'd like to ask you to add me to your RCS related patches as DevTools do > > now depend on RCS. Thanks! > > lpy can you check that cl? I think I accidentally closed the issue, I believe now it is reopened
hmmm, I think I added exactly `next && ...` and `if (next == nullptr) return;` in the same place in my patch here: https://codereview.chromium.org/2483583002, which got removed accidentally in cbruni's patch here: https://codereview.chromium.org/2490643002 So lgtm. And please add me to patches related to runtime stats in the future, thanks.
Description was changed from ========== [runtime stats] Fix crash after r41001 The timer can be missing in the timers stack when RCS is started dynamically. BUG=chromium:665659 ========== to ========== [runtime stats] Fix crash after r41001 The timer can be missing in the timers stack when RCS is started dynamically. BUG=chromium:665659 TBR=cbruni@chromium.org ==========
The CQ bit was checked by alph@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [runtime stats] Fix crash after r41001 The timer can be missing in the timers stack when RCS is started dynamically. BUG=chromium:665659 TBR=cbruni@chromium.org ========== to ========== [runtime stats] Fix crash after r41001 The timer can be missing in the timers stack when RCS is started dynamically. BUG=chromium:665659 TBR=cbruni@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
LGTM, sorry for the accidental revert...
Message was sent while issue was closed.
Description was changed from ========== [runtime stats] Fix crash after r41001 The timer can be missing in the timers stack when RCS is started dynamically. BUG=chromium:665659 TBR=cbruni@chromium.org ========== to ========== [runtime stats] Fix crash after r41001 The timer can be missing in the timers stack when RCS is started dynamically. BUG=chromium:665659 TBR=cbruni@chromium.org Committed: https://crrev.com/ca3f487979324c92f86e3ce88e8be9ac8579ecaa Cr-Commit-Position: refs/heads/master@{#41049} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ca3f487979324c92f86e3ce88e8be9ac8579ecaa Cr-Commit-Position: refs/heads/master@{#41049} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
