Chromium Code Reviews

Issue 2483583002: [Tracing] Fix inaccurate time accumulation in runtime statistics. (Closed)

Created:
4 years, 1 month ago by lpy
Modified:
4 years, 1 month ago
Reviewers:
fmeawad, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Tracing] Fix inaccurate time accumulation in runtime statistics. In tracing we collect runtime statistics data based on top level trace events, in this patch we force to clear the whole runtime statistics stack when we enter top level trace events. Committed: https://crrev.com/1f96226bc2d36c5a4f7fec84b7852ef4e06c3c7b Cr-Commit-Position: refs/heads/master@{#40867}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+11 lines, -5 lines)
M src/counters.cc View 3 chunks +10 lines, -4 lines 0 comments
M src/tracing/trace-event.cc View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 17 (10 generated)
lpy
ptal
4 years, 1 month ago (2016-11-08 03:55:18 UTC) #6
fmeawad
I have tried this CL on the top 25 pages and it seems to fix ...
4 years, 1 month ago (2016-11-08 23:23:59 UTC) #8
lpy
+ cbruni@, ptal.
4 years, 1 month ago (2016-11-08 23:54:18 UTC) #10
Camillo Bruni
lgtm
4 years, 1 month ago (2016-11-09 12:06:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2483583002/1
4 years, 1 month ago (2016-11-09 16:41:52 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 17:07:59 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:27:52 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f96226bc2d36c5a4f7fec84b7852ef4e06c3c7b
Cr-Commit-Position: refs/heads/master@{#40867}

Powered by Google App Engine