Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2505803002: Re-enable background:news:nytimes to examine crash (Closed)

Created:
4 years, 1 month ago by hjd
Modified:
4 years ago
Reviewers:
nednguyen, perezju
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable background:news:nytimes Also fixes the story for the Nexus7 BUG=664521 Committed: https://crrev.com/08e303fd2871c16b1fb675743e7548bc7e4feff9 Cr-Commit-Position: refs/heads/master@{#434497}

Patch Set 1 #

Patch Set 2 : fix story for n7 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/perf/page_sets/system_health/background_stories.py View 1 3 chunks +6 lines, -4 lines 1 comment Download

Messages

Total messages: 16 (9 generated)
nednguyen
lgtm
4 years, 1 month ago (2016-11-16 02:26:56 UTC) #2
hjd
ptal, thanks!
4 years ago (2016-11-25 13:05:00 UTC) #7
nednguyen
lgtm
4 years ago (2016-11-25 13:07:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505803002/20001
4 years ago (2016-11-25 13:34:24 UTC) #10
perezju
https://codereview.chromium.org/2505803002/diff/20001/tools/perf/page_sets/system_health/background_stories.py File tools/perf/page_sets/system_health/background_stories.py (right): https://codereview.chromium.org/2505803002/diff/20001/tools/perf/page_sets/system_health/background_stories.py#newcode68 tools/perf/page_sets/system_health/background_stories.py:68: action_runner.ScrollPageToElement(selector='.nytd-player-poster') I'm OK with this as a short-term fix, ...
4 years ago (2016-11-25 14:05:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-25 14:29:54 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-25 14:33:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/08e303fd2871c16b1fb675743e7548bc7e4feff9
Cr-Commit-Position: refs/heads/master@{#434497}

Powered by Google App Engine
This is Rietveld 408576698