Re-enable background:news:nytimes to examine crash

tools/perf/page_sets/system_health/background_stories.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from page_sets.system_health import platforms
 from page_sets.system_health import system_health_story
 from page_sets.system_health.loading_stories import LoadGmailMobileStory
 
-from telemetry import decorators
-
-
 _WAIT_FOR_VIDEO_SECONDS = 5
 
 class _BackgroundStory(system_health_story.SystemHealthStory):
   """Abstract base class for background stories
 
   As in _LoadingStory except it puts the browser into the
   background before measuring.
   """
   ABSTRACT_STORY = True
   SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
@@ skipping 13 matching lines @@
     action_runner.ScrollPageToElement(selector='g-fab')
     action_runner.TapElement(selector='g-fab')
 
 
 class BackgroundFacebookMobileStory(_BackgroundStory):
   NAME = 'background:social:facebook'
   URL = 'https://www.facebook.com/rihanna'
   SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
 
 
-@decorators.Disabled('android')  # crbug.com/664521
 class BackgroundNytimesMobileStory(_BackgroundStory):
   """The third top website in http://www.alexa.com/topsites/category/News"""
   NAME = 'background:news:nytimes'
   URL = 'http://www.nytimes.com/2016/10/04/us/politics/vice-presidential-debate.html?_r=0'
   SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
 
   def _DidLoadDocument(self, action_runner):
     # Dismiss the 'You have n free articles' message.
     action_runner.WaitForElement(selector='.growl-dismiss')
     action_runner.TapElement(selector='.growl-dismiss')
 
     # Tap the 'Show Full Article' button.
     action_runner.WaitForElement(selector='#additional-content button')
     action_runner.ScrollPageToElement(selector='#additional-content button')
     # TapElement seems flaky here so use JavaScript instead.
     action_runner.ExecuteJavaScript(
         'document.querySelector("#additional-content button").click()')
 
     # Scroll to video, start it and then wait for a few seconds.
     action_runner.WaitForElement(selector='.nytd-player-poster')
     action_runner.ScrollPageToElement(selector='.nytd-player-poster')
+    # For some reason on some devices (e.g. Nexus7) we don't scroll all the way
+    # to the element. I think this might be caused by the page reflowing (due to
+    # vidoes loading) during the scroll. To be sure we get to the element
+    # wait a moment and then try to scroll again.
+    action_runner.Wait(1)
+    action_runner.ScrollPageToElement(selector='.nytd-player-poster')

[perezju, 2016/11/25 14:05:40]

I'm OK with this as a short-term fix, but sounds like like an issue that should
be fixed in ScrollPageToElement?

i.e. the method should check whether it actually scrolled to the thing it was
supposed to, and either retry (like here) or fix whatever is causing it not to
reach the element in the first place?

     action_runner.TapElement(selector='.nytd-player-poster')
     action_runner.Wait(_WAIT_FOR_VIDEO_SECONDS)
 
 
 class BackgroundImgurMobileStory(_BackgroundStory):
   NAME = 'background:media:imgur'
   URL = 'http://imgur.com/gallery/hUita'
   SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
 
 
 class BackgroundGmailMobileStory(LoadGmailMobileStory):
   NAME = 'background:tools:gmail'
   SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
 
   def _Measure(self, action_runner):
     action_runner.tab.browser.Background()
     super(BackgroundGmailMobileStory, self)._Measure(action_runner)