Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2505713002: Switch monkey test to platform mode. (Closed)

Created:
4 years, 1 month ago by mikecase (-- gone --)
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch monkey test to platform mode. BUG=663127 Committed: https://crrev.com/a7fb522b96eadb5e710f8252d95ad242f2858788 Cr-Commit-Position: refs/heads/master@{#432695}

Patch Set 1 #

Patch Set 2 : Switch monkey test to platform mode. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -216 lines) Patch
M build/android/pylib/base/test_instance_factory.py View 2 chunks +3 lines, -0 lines 0 comments Download
M build/android/pylib/base/test_run_factory.py View 2 chunks +5 lines, -0 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 chunk +1 line, -0 lines 0 comments Download
A build/android/pylib/local/device/local_device_monkey_test_run.py View 1 1 chunk +126 lines, -0 lines 4 comments Download
A build/android/pylib/monkey/monkey_test_instance.py View 1 chunk +72 lines, -0 lines 0 comments Download
D build/android/pylib/monkey/setup.py View 1 1 chunk +0 lines, -27 lines 0 comments Download
M build/android/pylib/monkey/test_options.py View 1 1 chunk +0 lines, -16 lines 0 comments Download
M build/android/pylib/monkey/test_runner.py View 1 1 chunk +0 lines, -110 lines 0 comments Download
M build/android/test_runner.py View 1 6 chunks +15 lines, -60 lines 0 comments Download
M build/android/test_runner.pydeps View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mikecase (-- gone --)
Some minor improvements, like fixed some argument name --package arg renamed to --browser --category arg ...
4 years, 1 month ago (2016-11-15 23:39:39 UTC) #2
jbudorick
lgtm https://codereview.chromium.org/2505713002/diff/20001/build/android/pylib/local/device/local_device_monkey_test_run.py File build/android/pylib/local/device/local_device_monkey_test_run.py (right): https://codereview.chromium.org/2505713002/diff/20001/build/android/pylib/local/device/local_device_monkey_test_run.py#newcode73 build/android/pylib/local/device/local_device_monkey_test_run.py:73: # TODO(jbudorick): Update this after upstreaming. Well, this ...
4 years, 1 month ago (2016-11-16 00:14:03 UTC) #3
mikecase (-- gone --)
https://codereview.chromium.org/2505713002/diff/20001/build/android/pylib/local/device/local_device_monkey_test_run.py File build/android/pylib/local/device/local_device_monkey_test_run.py (right): https://codereview.chromium.org/2505713002/diff/20001/build/android/pylib/local/device/local_device_monkey_test_run.py#newcode73 build/android/pylib/local/device/local_device_monkey_test_run.py:73: # TODO(jbudorick): Update this after upstreaming. On 2016/11/16 at ...
4 years, 1 month ago (2016-11-16 22:48:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505713002/20001
4 years, 1 month ago (2016-11-17 00:10:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 01:54:05 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 02:07:11 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7fb522b96eadb5e710f8252d95ad242f2858788
Cr-Commit-Position: refs/heads/master@{#432695}

Powered by Google App Engine
This is Rietveld 408576698