Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: build/android/test_runner.py

Issue 2505713002: Switch monkey test to platform mode. (Closed)
Patch Set: Switch monkey test to platform mode. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/test_runner.py
diff --git a/build/android/test_runner.py b/build/android/test_runner.py
index 42429d32dccd8dc8af79437d8ae43780580f8e01..92c335fb3a13d7d431ba74ba1e8cd0f44157a79b 100755
--- a/build/android/test_runner.py
+++ b/build/android/test_runner.py
@@ -36,8 +36,6 @@ from pylib.constants import host_paths
from pylib.linker import setup as linker_setup
from pylib.junit import setup as junit_setup
from pylib.junit import test_dispatcher as junit_dispatcher
-from pylib.monkey import setup as monkey_setup
-from pylib.monkey import test_options as monkey_test_options
from pylib.results import json_results
from pylib.results import report_results
@@ -423,53 +421,32 @@ def AddMonkeyTestOptions(parser):
group = parser.add_argument_group('Monkey Test Options')
group.add_argument(
- '--package', required=True, choices=constants.PACKAGE_INFO.keys(),
- metavar='PACKAGE', help='Package under test.')
+ '--browser', required=True, choices=constants.PACKAGE_INFO.keys(),
+ metavar='BROWSER', help='Browser under test.')
group.add_argument(
'--event-count', default=10000, type=int,
help='Number of events to generate (default: %(default)s).')
group.add_argument(
- '--category', default='',
- help='A list of allowed categories.')
+ '--category', nargs='*', dest='categories', default=[],
+ help='A list of allowed categories. Monkey will only visit activities '
+ 'that are listed with one of the specified categories.')
group.add_argument(
'--throttle', default=100, type=int,
help='Delay between events (ms) (default: %(default)s). ')
group.add_argument(
'--seed', type=int,
- help=('Seed value for pseudo-random generator. Same seed value generates '
- 'the same sequence of events. Seed is randomized by default.'))
+ help='Seed value for pseudo-random generator. Same seed value generates '
+ 'the same sequence of events. Seed is randomized by default.')
group.add_argument(
- '--extra-args', default='',
- help=('String of other args to pass to the command verbatim.'))
-
+ '--repeat', dest='repeat', type=int, default=0,
+ help='Number of times to repeat the specified set of tests.')
+ group.add_argument(
+ '--break-on-failure', '--break_on_failure',
+ dest='break_on_failure', action='store_true',
+ help='Whether to break on failure.')
AddCommonOptions(parser)
AddDeviceOptions(parser)
-def ProcessMonkeyTestOptions(args):
- """Processes all monkey test options.
-
- Args:
- args: argparse.Namespace object.
-
- Returns:
- A MonkeyOptions named tuple which contains all options relevant to
- monkey tests.
- """
- # TODO(jbudorick): Handle this directly in argparse with nargs='+'
- category = args.category
- if category:
- category = args.category.split(',')
-
- # TODO(jbudorick): Get rid of MonkeyOptions.
- return monkey_test_options.MonkeyOptions(
- args.verbose_count,
- args.package,
- args.event_count,
- category,
- args.throttle,
- args.seed,
- args.extra_args)
-
def AddPerfTestOptions(parser):
"""Adds perf test options to |parser|."""
@@ -605,27 +582,6 @@ def _RunJUnitTests(args):
return exit_code
-def _RunMonkeyTests(args, devices):
- """Subcommand of RunTestsCommands which runs monkey tests."""
- monkey_options = ProcessMonkeyTestOptions(args)
-
- runner_factory, tests = monkey_setup.Setup(monkey_options)
-
- results, exit_code = test_dispatcher.RunTests(
- tests, runner_factory, devices, shard=False, test_timeout=None,
- num_retries=args.num_retries)
-
- report_results.LogFull(
- results=results,
- test_type='Monkey',
- test_package='Monkey')
-
- if args.json_results_file:
- json_results.GenerateJsonResultsFile([results], args.json_results_file)
-
- return exit_code
-
-
def _RunPythonTests(args):
"""Subcommand of RunTestsCommand which runs python unit tests."""
suite_vars = constants.PYTHON_UNIT_TEST_SUITES[args.suite_name]
@@ -675,7 +631,7 @@ def _GetAttachedDevices(blacklist_file, test_device, enable_cache, num_retries):
return sorted(attached_devices)
-_DEFAULT_PLATFORM_MODE_TESTS = ['gtest', 'instrumentation', 'perf']
+_DEFAULT_PLATFORM_MODE_TESTS = ['gtest', 'instrumentation', 'monkey', 'perf']
def RunTestsCommand(args): # pylint: disable=too-many-return-statements
@@ -715,8 +671,6 @@ def RunTestsCommand(args): # pylint: disable=too-many-return-statements
return _RunLinkerTests(args, get_devices())
elif command == 'junit':
return _RunJUnitTests(args)
- elif command == 'monkey':
- return _RunMonkeyTests(args, get_devices())
elif command == 'python':
return _RunPythonTests(args)
else:
@@ -728,6 +682,7 @@ _SUPPORTED_IN_PLATFORM_MODE = [
'gtest',
'instrumentation',
'junit',
+ 'monkey',
'perf',
]

Powered by Google App Engine
This is Rietveld 408576698