Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2505653003: [Mac[ FullscreenToolbarController Refactor (Closed)

Created:
4 years, 1 month ago by spqchan
Modified:
4 years, 1 month ago
Reviewers:
Robert Sesek, erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] FullscreenToolbarController Refactor No intentional behavioral changes - Rearranged the functions so that the order matches the header file - Removed unnecessary imports - Renamed functions BUG=643418 Committed: https://crrev.com/9dd1729a24326039f5b4cd36d6697e97af0d2938 Cr-Commit-Position: refs/heads/master@{#432644}

Patch Set 1 #

Patch Set 2 : Cleaned up #

Patch Set 3 : nits #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -461 lines) Patch
M chrome/browser/ui/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h View 1 5 chunks +32 lines, -24 lines 1 comment Download
A + chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm View 1 2 6 chunks +53 lines, -68 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_visibility_lock_controller.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h View 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm View 1 chunk +0 lines, -206 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
spqchan
PTAL
4 years, 1 month ago (2016-11-16 17:39:56 UTC) #7
erikchen
lgtm https://codereview.chromium.org/2505653003/diff/40001/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h File chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h (right): https://codereview.chromium.org/2505653003/diff/40001/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h#newcode35 chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h:35: struct FullscreenToolbarLayout { Nice.
4 years, 1 month ago (2016-11-16 18:52:35 UTC) #8
spqchan
thanks! +rsesek for ownership
4 years, 1 month ago (2016-11-16 20:15:32 UTC) #10
Robert Sesek
LGTM! More nice cleanup :)
4 years, 1 month ago (2016-11-16 21:54:05 UTC) #11
spqchan
On 2016/11/16 21:54:05, Robert Sesek wrote: > LGTM! More nice cleanup :) thanks!
4 years, 1 month ago (2016-11-16 22:03:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505653003/40001
4 years, 1 month ago (2016-11-16 22:04:39 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-16 22:22:53 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 22:34:32 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9dd1729a24326039f5b4cd36d6697e97af0d2938
Cr-Commit-Position: refs/heads/master@{#432644}

Powered by Google App Engine
This is Rietveld 408576698