Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 2505653003: [Mac[ FullscreenToolbarController Refactor (Closed)
Patch Set: nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/browser_window_controller.h" 5 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #import "base/mac/mac_util.h" 8 #import "base/mac/mac_util.h"
9 9
10 #include "base/mac/sdk_forward_declarations.h" 10 #include "base/mac/sdk_forward_declarations.h"
(...skipping 15 matching lines...) Expand all
26 #include "chrome/browser/ui/browser_navigator_params.h" 26 #include "chrome/browser/ui/browser_navigator_params.h"
27 #include "chrome/browser/ui/browser_window.h" 27 #include "chrome/browser/ui/browser_window.h"
28 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h" 28 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
29 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h" 29 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
30 #import "chrome/browser/ui/cocoa/fast_resize_view.h" 30 #import "chrome/browser/ui/cocoa/fast_resize_view.h"
31 #import "chrome/browser/ui/cocoa/history_overlay_controller.h" 31 #import "chrome/browser/ui/cocoa/history_overlay_controller.h"
32 #import "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h" 32 #import "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h"
33 #import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h" 33 #import "chrome/browser/ui/cocoa/infobars/infobar_container_controller.h"
34 #import "chrome/browser/ui/cocoa/infobars/infobar_controller.h" 34 #import "chrome/browser/ui/cocoa/infobars/infobar_controller.h"
35 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" 35 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
36 #import "chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h" 36 #import "chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h"
37 #import "chrome/browser/ui/cocoa/profiles/avatar_base_controller.h" 37 #import "chrome/browser/ui/cocoa/profiles/avatar_base_controller.h"
38 #import "chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h" 38 #import "chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h"
39 #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h" 39 #import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"
40 #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h" 40 #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
41 #include "chrome/browser/ui/exclusive_access/fullscreen_controller.h" 41 #include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
42 #include "chrome/browser/ui/exclusive_access/fullscreen_controller_test.h" 42 #include "chrome/browser/ui/exclusive_access/fullscreen_controller_test.h"
43 #include "chrome/browser/ui/extensions/application_launch.h" 43 #include "chrome/browser/ui/extensions/application_launch.h"
44 #include "chrome/browser/ui/find_bar/find_bar.h" 44 #include "chrome/browser/ui/find_bar/find_bar.h"
45 #include "chrome/browser/ui/find_bar/find_bar_controller.h" 45 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
46 #include "chrome/browser/ui/infobar_container_delegate.h" 46 #include "chrome/browser/ui/infobar_container_delegate.h"
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 timer.Start( 346 timer.Start(
347 FROM_HERE, 347 FROM_HERE,
348 base::TimeDelta::FromMilliseconds(15), 348 base::TimeDelta::FromMilliseconds(15),
349 base::Bind(&CheckBookmarkBarAnimation, 349 base::Bind(&CheckBookmarkBarAnimation,
350 [controller() bookmarkBarController], 350 [controller() bookmarkBarController],
351 runner->QuitClosure())); 351 runner->QuitClosure()));
352 runner->Run(); 352 runner->Run();
353 } 353 }
354 354
355 void VerifyFullscreenToolbarVisibility(FullscreenToolbarStyle style) { 355 void VerifyFullscreenToolbarVisibility(FullscreenToolbarStyle style) {
356 EXPECT_EQ([[controller() fullscreenToolbarController] toolbarStyle], style); 356 EXPECT_EQ(
357 [[controller() fullscreenToolbarController] computeLayout].toolbarStyle,
358 style);
357 359
358 NSRect toolbarFrame = [[[controller() toolbarController] view] frame]; 360 NSRect toolbarFrame = [[[controller() toolbarController] view] frame];
359 NSRect screenFrame = [[[controller() window] screen] frame]; 361 NSRect screenFrame = [[[controller() window] screen] frame];
360 if (style == FullscreenToolbarStyle::TOOLBAR_PRESENT) 362 if (style == FullscreenToolbarStyle::TOOLBAR_PRESENT)
361 EXPECT_LE(NSMaxY(toolbarFrame), NSMaxY(screenFrame)); 363 EXPECT_LE(NSMaxY(toolbarFrame), NSMaxY(screenFrame));
362 else 364 else
363 EXPECT_GE(NSMinY(toolbarFrame), NSMaxY(screenFrame)); 365 EXPECT_GE(NSMinY(toolbarFrame), NSMaxY(screenFrame));
364 } 366 }
365 367
366 NSInteger GetExpectedTopInfoBarTipHeight() { 368 NSInteger GetExpectedTopInfoBarTipHeight() {
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 EXPECT_FALSE([fullscreenToolbarController isRevealingToolbarForTabstrip]); 797 EXPECT_FALSE([fullscreenToolbarController isRevealingToolbarForTabstrip]);
796 [fullscreenToolbarController resetToolbarFlag]; 798 [fullscreenToolbarController resetToolbarFlag];
797 799
798 // Switch to a non-NTP tab. 800 // Switch to a non-NTP tab.
799 TabStripModel* model = browser()->tab_strip_model(); 801 TabStripModel* model = browser()->tab_strip_model();
800 model->ActivateTabAt(1, true); 802 model->ActivateTabAt(1, true);
801 ASSERT_FALSE([[controller() toolbarController] isLocationBarFocused]); 803 ASSERT_FALSE([[controller() toolbarController] isLocationBarFocused]);
802 EXPECT_TRUE([fullscreenToolbarController isRevealingToolbarForTabstrip]); 804 EXPECT_TRUE([fullscreenToolbarController isRevealingToolbarForTabstrip]);
803 [fullscreenToolbarController resetToolbarFlag]; 805 [fullscreenToolbarController resetToolbarFlag];
804 } 806 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698