Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2505573002: CustomElements: createCustomElementSync accepts a definition (Closed)

Created:
4 years, 1 month ago by yurak
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CustomElement::createCustomElementSync can accept a CustomElementDefinition. BUG=648828 Committed: https://crrev.com/930362923fecec7e947400e44a06983fffa75f24 Cr-Commit-Position: refs/heads/master@{#433169}

Patch Set 1 #

Patch Set 2 : createCustomElementSync accepts a definition #

Total comments: 1

Patch Set 3 : createCustomElementSync accepts a definition #

Patch Set 4 : createCustomElementSync accepts a definition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -31 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElement.h View 1 2 1 chunk +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElement.cpp View 1 4 chunks +35 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
yurak
PTL
4 years, 1 month ago (2016-11-15 12:45:59 UTC) #3
dominicc (has gone to gerrit)
LGTM, one optional comment inline. https://codereview.chromium.org/2505573002/diff/20001/third_party/WebKit/Source/core/dom/custom/CustomElement.h File third_party/WebKit/Source/core/dom/custom/CustomElement.h (right): https://codereview.chromium.org/2505573002/diff/20001/third_party/WebKit/Source/core/dom/custom/CustomElement.h#newcode67 third_party/WebKit/Source/core/dom/custom/CustomElement.h:67: static bool shouldCreateCustomizedBuiltinElement(const AtomicString&); ...
4 years, 1 month ago (2016-11-17 01:39:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505573002/60001
4 years, 1 month ago (2016-11-18 08:14:58 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-18 10:41:43 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 10:43:29 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/930362923fecec7e947400e44a06983fffa75f24
Cr-Commit-Position: refs/heads/master@{#433169}

Powered by Google App Engine
This is Rietveld 408576698