CustomElements: createCustomElementSync accepts a definition

third_party/WebKit/Source/core/dom/custom/CustomElement.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CustomElement_h
 #define CustomElement_h
 
 #include "core/CoreExport.h"
 #include "core/HTMLNames.h"
 #include "core/dom/Element.h"
@@ skipping 44 matching lines @@
         UChar32 ch;
         U16_NEXT(characters, i, name.length(), ch);
         if (!Character::isPotentialCustomElementNameChar(ch))
           return false;
       }
     }
 
     return !isHyphenatedSpecElementName(name);
   }
 
-  static bool shouldCreateCustomElement(const AtomicString& localName);
+  static bool shouldCreateCustomElement(const AtomicString&);
   static bool shouldCreateCustomElement(const QualifiedName&);
+  static bool shouldCreateCustomizedBuiltinElement(const AtomicString&);

[dominicc (has gone to gerrit), 2016/11/17 01:39:21]

I think you *do* want to name this parameter. It's a local name, right? To
contrast it to shouldCreateCustomElement (that one's a custom element name, not
necessarily a tag name.)

+  static bool shouldCreateCustomizedBuiltinElement(const QualifiedName&);
 
-  static HTMLElement* createCustomElementSync(
-      Document&,
-      const AtomicString& localName,
-      const AtomicString& is = AtomicString());
-  static HTMLElement* createCustomElementSync(
-      Document&,
-      const QualifiedName&,
-      const AtomicString& is = AtomicString());
+  static HTMLElement* createCustomElementSync(Document&, const QualifiedName&);
+  static HTMLElement* createCustomElementSync(Document&,
+                                              const AtomicString& localName,
+                                              CustomElementDefinition*);
+  static HTMLElement* createCustomElementSync(Document&,
+                                              const QualifiedName&,
+                                              CustomElementDefinition*);
   static HTMLElement* createCustomElementAsync(Document&, const QualifiedName&);
 
   static HTMLElement* createFailedElement(Document&, const QualifiedName&);
 
   static void enqueue(Element*, CustomElementReaction*);
   static void enqueueConnectedCallback(Element*);
   static void enqueueDisconnectedCallback(Element*);
   static void enqueueAdoptedCallback(Element*,
                                      Document* oldOwner,
                                      Document* newOwner);
   static void enqueueAttributeChangedCallback(Element*,
                                               const QualifiedName&,
                                               const AtomicString& oldValue,
                                               const AtomicString& newValue);
 
   static void tryToUpgrade(Element*);
 
  private:
   // Some existing specs have element names with hyphens in them,
   // like font-face in SVG. The custom elements spec explicitly
   // disallows these as custom element names.
   // https://html.spec.whatwg.org/#valid-custom-element-name
   static bool isHyphenatedSpecElementName(const AtomicString&);
   static HTMLElement* createUndefinedElement(Document&, const QualifiedName&);
 };
 
 }  // namespace blink
 
 #endif  // CustomElement_h