Fix visible viewport in LayoutManager

Fix visible viewport in LayoutManager

There are corner cases where the browser process determines what the
browser's controls should be doing rather than the renderer. In these
cases the visible viewport needs to include space off-screen to
account for the content offset changing.

BUG=664956, 662427
Committed: https://crrev.com/24192fe5a799a1348671885882d24a826e0e1e21
Cr-Commit-Position: refs/heads/master@{#432091}

[mdjones, 2016-11-15 01:00:33]

mdjones@chromium.org changed reviewers:
+ aelias@chromium.org

[mdjones, 2016-11-15 01:00:33]

This re-adds the adjustments that I removed from the CompositorView in
https://codereview.chromium.org/2482233002/

ptal

[aelias_OOO_until_Jul13, 2016-11-15 01:05:11]

lgtm.  Note that I have some local pending patches that A) remove the
browser-controlled position from FullscreenManager, and B) turn off clipping in
static tab layout, either one of which would fix this, but they are hard to land
without causing other potential problems, so let's go with this for now as a
regression fix.

[mdjones, 2016-11-15 01:11:20]

On 2016/11/15 01:05:11, aelias wrote:
> lgtm.  Note that I have some local pending patches that A) remove the
> browser-controlled position from FullscreenManager, and B) turn off clipping
in
> static tab layout, either one of which would fix this, but they are hard to
land
> without causing other potential problems, so let's go with this for now as a
> regression fix.

Ted also has some changes that would affect this
(https://codereview.chromium.org/2484293003/). It is by no means supposed to be
a permanent solution. At the latest, this should be gone when I'm done
straightening out the viewports.

[mdjones, 2016-11-15 01:14:03]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2016-11-15 01:14:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2016-11-15 01:18:01]

On 2016/11/15 at 01:11:20, mdjones wrote:
> Ted also has some changes that would affect this
(https://codereview.chromium.org/2484293003/). It is by no means supposed to be
a permanent solution. At the latest, this should be gone when I'm done
straightening out the viewports.

Sounds good, that's what I had in mind for A.  My patch for B is
https://codereview.chromium.org/2499863002/

[commit-bot: I haz the power, 2016-11-15 04:04:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-15 04:06:45]

Description was changed from

==========
Fix visible viewport in LayoutManager

There are corner cases where the browser process determines what the
browser's controls should be doing rather than the renderer. In these
cases the visible viewport needs to include space off-screen to
account for the content offset changing.

BUG=664956, 662427
==========

to

==========
Fix visible viewport in LayoutManager

There are corner cases where the browser process determines what the
browser's controls should be doing rather than the renderer. In these
cases the visible viewport needs to include space off-screen to
account for the content offset changing.

BUG=664956, 662427

Committed: https://crrev.com/24192fe5a799a1348671885882d24a826e0e1e21
Cr-Commit-Position: refs/heads/master@{#432091}
==========

[commit-bot: I haz the power, 2016-11-15 04:06:45]

Patchset 1 (id:??) landed as
https://crrev.com/24192fe5a799a1348671885882d24a826e0e1e21
Cr-Commit-Position: refs/heads/master@{#432091}