Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

Issue 2505463002: Fix visible viewport in LayoutManager (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
index 17a70c9ec29c45127325582560bb8a5725de472f..2c8f08e0052d7eab1dde572bb606a042b0fbdfe5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
@@ -282,6 +282,11 @@ public abstract class LayoutManager implements LayoutUpdateHost, LayoutProvider,
TabContentManager tabContentManager, ResourceManager resourceManager,
ChromeFullscreenManager fullscreenManager) {
getViewportPixel(mCachedVisibleViewport);
+ // TODO(mdjones): The concept of visible viewport is pretty confising since |viewport| can
+ // also take the browser controls into consideration; this should be made more clear.
+ // Furthermore, the below adjustments should not be necessary.
+ mCachedVisibleViewport.right = mCachedVisibleViewport.left + mHost.getWidth();
+ mCachedVisibleViewport.bottom = mCachedVisibleViewport.top + mHost.getHeight();
return mActiveLayout.getUpdatedSceneLayer(viewport, mCachedVisibleViewport, layerTitleCache,
tabContentManager, resourceManager, fullscreenManager);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698