Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4615)

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h

Issue 2505443003: Make sure all paths out of the dialog properly unregister observers. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
index 76c2033be2c93ebad8ef492fd9ba39a2ce27bc7d..839f0116fcb05be10563f340a7c125e50b76c3c5 100644
--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.h
@@ -67,10 +67,18 @@ class JavaScriptDialogTabHelper
private:
friend class content::WebContentsUserData<JavaScriptDialogTabHelper>;
+ // Wrapper around a DialogClosedCallback so that we can intercept it before
+ // passing it onto the original callback.
+ void OnDialogClosed(DialogClosedCallback callback,
+ bool success,
+ const base::string16& user_input);
+
void CloseDialog(bool suppress_callback,
bool success,
const base::string16& user_input);
+ void ClearDialogInfo();
+
// The dialog being displayed on the observed WebContents.
base::WeakPtr<JavaScriptDialog> dialog_;
« no previous file with comments | « no previous file | chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698