Fix Ctrl-A then Ctrl-X infinite loop in quick_launch.

Fix Ctrl-A then Ctrl-X infinite loop in quick_launch.

Before this change, QuickLaunchUI::ContentsChanged() went to an infinite loop
if (!suggestion_rejected_ && new_contents.length() == 0). This is because
base::ReplaceSubstringsAfterOffset() expects a non-empty string to find. If
DCHECK is off, this function goes to an infinite loop, otherwise it crashes.

BUG=666113
Committed: https://crrev.com/f7f3104c87c624b39cb0df461bd45c29bf8387c9
Cr-Commit-Position: refs/heads/master@{#433000}

[Hadi, 2016-11-17 20:27:33]

moshayedi@chromium.org changed reviewers:
+ ben@chromium.org

[Hadi, 2016-11-17 20:27:34]

PTAL.

[sadrul, 2016-11-17 20:32:46]

sadrul@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2016-11-17 20:32:47]

lgtm

https://codereview.chromium.org/2505283003/diff/1/mash/quick_launch/quick_lau...
File mash/quick_launch/quick_launch.cc (right):

https://codereview.chromium.org/2505283003/diff/1/mash/quick_launch/quick_lau...
mash/quick_launch/quick_launch.cc:99: if (new_contents.length() == 0)
new_contents.empty()

[Hadi, 2016-11-17 20:44:05]

The CQ bit was checked by moshayedi@chromium.org to run a CQ dry run

[Hadi, 2016-11-17 20:44:32]

https://codereview.chromium.org/2505283003/diff/1/mash/quick_launch/quick_lau...
File mash/quick_launch/quick_launch.cc (right):

https://codereview.chromium.org/2505283003/diff/1/mash/quick_launch/quick_lau...
mash/quick_launch/quick_launch.cc:99: if (new_contents.length() == 0)
On 2016/11/17 20:32:46, sadrul wrote:
> new_contents.empty()

Done.

[commit-bot: I haz the power, 2016-11-17 20:45:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-11-17 21:26:40]

lgtm

[Hadi, 2016-11-17 22:01:02]

The CQ bit was unchecked by moshayedi@chromium.org

[Hadi, 2016-11-17 22:01:05]

The CQ bit was checked by moshayedi@chromium.org

[Hadi, 2016-11-17 22:01:05]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2505283003/#ps20001
(title: "Addressed feedback.")

[commit-bot: I haz the power, 2016-11-17 22:03:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 22:55:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:58:13]

Description was changed from

==========
Fix Ctrl-A then Ctrl-X infinite loop in quick_launch.

Before this change, QuickLaunchUI::ContentsChanged() went to an infinite loop
if (!suggestion_rejected_ && new_contents.length() == 0). This is because
base::ReplaceSubstringsAfterOffset() expects a non-empty string to find. If
DCHECK is off, this function goes to an infinite loop, otherwise it crashes.

BUG=666113
==========

to

==========
Fix Ctrl-A then Ctrl-X infinite loop in quick_launch.

Before this change, QuickLaunchUI::ContentsChanged() went to an infinite loop
if (!suggestion_rejected_ && new_contents.length() == 0). This is because
base::ReplaceSubstringsAfterOffset() expects a non-empty string to find. If
DCHECK is off, this function goes to an infinite loop, otherwise it crashes.

BUG=666113

Committed: https://crrev.com/f7f3104c87c624b39cb0df461bd45c29bf8387c9
Cr-Commit-Position: refs/heads/master@{#433000}
==========

[commit-bot: I haz the power, 2016-11-17 22:58:14]

Patchset 2 (id:??) landed as
https://crrev.com/f7f3104c87c624b39cb0df461bd45c29bf8387c9
Cr-Commit-Position: refs/heads/master@{#433000}